• Lines 498-520 change the appearance of most input types but leave out input[type=tel]. I’d add that selector OR refactor the form styles so all inputs have that styles and then opt-out input[type=”submit”] (more future-proof).

    Edit: There are also some other HTML5 ones missing like number.

Viewing 10 replies - 1 through 10 (of 10 total)
  • Moderator Kathryn Presner

    (@zoonini)

    Thanks for the suggestion – I’ll pass these suggestions along to our developers for consideration in an update.

    Thread Starter mrwweb

    (@mrwweb)

    This is technically a separate issue but related enough that I’ll tack it on here. When a form is placed in the sidebar, the background color and border color of inputs is very low contrast and so it’s hard to see the form fields at all.

    Moderator Kathryn Presner

    (@zoonini)

    Hi Mark, I put a search form in both the right sidebar and the footer but both look OK to me:

    kp test site a very nice tagline

    A screenshot of what you’re seeing would be helpful so I can try to replicate it. Thanks!

    This is probably also not something we’d be able to change at this stage, but fortunately easy to tweak with CSS.

    Thread Starter mrwweb

    (@mrwweb)

    Just checked. That’s because the search widget input is specifically styled rather than a general cascading rule to handle inputs in sidebars:

    .widget .search-field { /* this is a very specific rule! */
    	background: #fff;
    }

    Here’s a Gravity Form in the sidebar (without the custom css I wrote): https://cloudup.com/cFheW965uOb

    Moderator Kathryn Presner

    (@zoonini)

    Got it. Thanks for the screenshot, I’ll pass it along to our developers.

    Moderator Kathryn Presner

    (@zoonini)

    Version 1.1.4 of Sequential is now available and should fix the input field background colour issue, which was the second issue reported in this thread.

    The initial issue mentioned is still in our system as a possible future enhancement but has not been added yet.

    Thread Starter mrwweb

    (@mrwweb)

    That’s great! I hope they fix the other issue too, but any improvement is a good improvement ??

    Thanks for letting me know.

    Thread Starter mrwweb

    (@mrwweb)

    So this bug report sent me on a bit of an odyssey that ended with an issue and accepted pull request on _s where I think this issue originated from. The new code now includes all input types!

    Now that the code has gone in upstream, I hope you’ll consider pulling in those changes to Sequential and other Automattic themes that have the same problem (I know Sela does and I’m sure it’s not the only one)!

    Moderator Kathryn Presner

    (@zoonini)

    That’s great that your patch is now in Underscores – that’ll be useful for new themes going forward.

    I hope you’ll consider pulling in those changes to Sequential

    The enhancement ticket is still in our queue for Sequential. We’ll keep you posted here.

    I spoke with our developers, and for a tweak like this, we’ll go back and modify old themes on a case-by-case basis.

    Thread Starter mrwweb

    (@mrwweb)

    we’ll go back and modify old themes on a case-by-case basis.

    Totally understand that seeing that some themes may include tweaks. That said, I believe both Sequential and Sela had the code verbatim, so I’d hope that the changes would both be easy and not too risky. Fingers crossed!

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘No styles for input[type="tel"]’ is closed to new replies.