No emails if retry the payment

hmm i managed to solve this a sort of a way by checking the order status failed or pending and update the status into complete when in transaction complete in my payment gateway!.But still the issue is there for BACS!

if ($order->status == 'pending' || $order->status == 'failed') {
						//$order->update_status( 'on-hold' );
						$order->update_status('completed',"payment complete");
					}

					$order->payment_complete();

What was the order status transition? Look at the order notes.

its Awaiting BACS payment Order status changed from Failed to On Hold.

Since this is on-hold, only admin will get an email until you process it.

hmm but the email went if we manage to transfer at the first time.but if i failed first attempt and try the second time using pay button no email will trigger.(Ex: lets say i got an issue when pay by credit card came back and added bank transfer and proceeded).How i can identify this is a second attempt and then trigger the email?As you said its on hold!. Can i add a function like this

if ($order->status == 'pending' || $order->status == 'failed') {
	$order->update_status( 'on-hold', __( 'Awaiting BACS payment', 'woocommerce' ) );
		}

if i can how i should add that?

I don’t understand the question. The gateway already sets the order to on-hold once it actually goes through?

i manged to get by adding the code as follows to BACS.

if ($order->status == 'failed') {

			$order->update_status( 'pending', __( 'Awaiting BACS payment', 'woocommerce' ) );
		}
			$order->update_status( 'on-hold', __( 'Awaiting BACS payment', 'woocommerce' ) );

Is this a theme related issue or something other because obviously an email should go to inform customer?

how it happened for me as this..(test method)
1.try to pay using credit card and it fails.
2.then a notice should come the payment failed but there is a pay button to try again.(admin get a notice as a failed order but not the customer-it’s OK!)
3.i click on pay button and come to checkout page and this time select direct bank transfer.and it succeed.
4.So now an confirmation email should go to customer as order is now recorded correctly (but it doesn’t-was my question)
what i did:-
So i added that code (obviously if previous attempt failed order status is failed.so i change it to pending again and set it to on hold then the order confirmation email triggered).Don’t know whether this a common issue or not,but this is what i experienced.

So now an email should go to customer as order is on-hold(but it doesn’t-was my question)

This is not right. I said earlier, only admin get notifications for on-hold orders.

Hi Oops that was my bad. i reedited my comment.

Ill patch 2.6 to include this email ??

https://github.com/woothemes/woocommerce/commit/f47e9f4af5cdeffdfabed5cefe071dec0650b385

Oh Thanks! Hope i was helpful.