Nice work, but needs improvement

@ggedde thanks for the feedback, though it would have been more appreciated as a support request of areas you feel need enhancing/fixing. Regardless, I’m responding below to each of your concerns.

First it doesn’t remove the default Profile Picture. Meaning you will see 2 sections in the Admin > Users for user photo. This confuses clients. There should be an option to hide the default Profile Picture or it should just do it automatically when this is enabled.

I just tested a couple other “avatar” plugins and most also keep the “Profile Picture” display within a user’s Profile page, though I do agree that can seem confusing. I’m going to do a little research in WordPress core to see if there’s a reason we aren’t hiding that, if we’re safe to hide that section then I’ll open a GitHub issue to track that work.

Secondly, a minor issue is that the Admin setting for this is under Settings > Discussion. Which is fine, but I use “Disable Comments” which hides Settings > Discussion so I have no way of making Admin settings changes to this.

The reason the admin settings are in Settings > Discussion is because the WordPress core “Avatars” settings are already located there so it makes most sense to include Simple Local Avatars settings there as well. It sounds more like “Disable Comments” is doing things wrong by blindly hiding that entire settings page (and frankly I’m surprised their users have not complained that they’re unable to update their Avatars settings because of this).

Also most Plugins that have a settings page would have a settings link in the Plugins page underneath it’s name and this does not making it hard to find where the settings page is, but the author does explain this in their documentation.

Again, I do not feel a specific settings page for Simple Local Avatars makes sense since there already is the Avatars settings in WordPress core within the Settings > Discussion settings page and because too many plugins add new settings pages that clutter the WP Admin when finding a more natural, pre-existing core Settings page to integrate into would help keep things a bit more tidy in the admin. However, I do see where we could add a link to that settings page from the Plugins page and have added a GitHub issue to track our work on this.

I was also confused about where to find settings and agree with the proposed solution of adding:

a “Settings” link under the plugin name on the Installed Plugins page (e.g. wp-admin/plugins.php) that links to wp-admin/options-discussion.php to better help direct admins on where to customize their SLA experience.

@ggedde @rdela note that Simple Local Avatars 2.3.0 was recently released and includes a “Settings” link after installing/updating and should now direct you to the WP Admin page to adjust the settings for the plugin functionality.