[NextGEN Custom Fields] Bug? When copy a picture in an other gallery lose values

Hey mcseller

Thanks for pointing out the problem. I didn’t even know you could copy images between galleries in NextGEN ??

I will try look at it this weekend, but I am heading away on holiday next week so I can’t be sure I will get a chance.

Thanks again!

Hey shauno,

thanks for your answer ??

If can help you, here is my hack code in NextGEN Gallery plugin. It works well for me, but I’m sure you can find a better solution. One more think: I just added lines and you can recognize them because all of them begins and ends with “by M.C.” words.

file: lib/ngg-db.php – function delete_gallery

function delete_gallery( $id ) {
global $wpdb;

/* by M.C. – Added Lines – Delete Custom Fields Too! */
/* NextGEN Custom Fields Patch */
if ( function_exists ( ‘nggcf_save_pics’ ) )
{
if ( $mcRecords = $wpdb -> get_results ( “SELECT * FROM ” . $wpdb -> nggpictures. ” WHERE galleryid = ” . $this -> id ) )
{
foreach ( $mcRecords as $mcRecord )
$wpdb -> query ( “DELETE FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=1 AND pid = ” . $mcRecord -> pid );
}
$wpdb -> query ( “DELETE FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=2 AND pid = ” . $this -> id );
}
/* NextGEN Custom Fields Patch */
/* by M.C. – Added Lines – Delete Custom Fields Too! */

$wpdb->query( $wpdb->prepare( “DELETE FROM $wpdb->nggpictures WHERE galleryid = %d”, $id) );
$wpdb->query( $wpdb->prepare( “DELETE FROM $wpdb->nggallery WHERE gid = %d”, $id) );

wp_cache_delete($id, ‘ngg_gallery’);

//TODO:Remove all tag relationship
return true;
}

file: lib/ngg-db.php – function delete_image

function delete_image( $id ) {
global $wpdb;

// Delete the image
$result = $wpdb->query( $wpdb->prepare( “DELETE FROM $wpdb->nggpictures WHERE pid = %d”, $id) );

// Delete tag references
wp_delete_object_term_relationships( $id, ‘ngg_tag’);

// Remove from cache
wp_cache_delete( $id, ‘ngg_image’);

/* by M.C. – Added Lines – Delete Custom Fields Too! */
/* NextGEN Custom Fields Patch */
if ( function_exists ( ‘nggcf_save_pics’ ) )
$wpdb -> query ( “DELETE FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=1 AND pid = ” . $id );
/* NextGEN Custom Fields Patch */
/* by M.C. – Added Lines – Delete Custom Fields Too! */

return $result;
}

file: admin/functions.php – function copy_images

function copy_images($pic_ids, $dest_gid) {

$errors = $messages = ”;

if (!is_array($pic_ids))
$pic_ids = array($pic_ids);

// Get destination gallery
$destination = nggdb::find_gallery( $dest_gid );
if ( $destination == null ) {
nggGallery::show_error(__(‘The destination gallery does not exist’,’nggallery’));
return;
}

// Check for folder permission
if (!is_writeable(WINABSPATH.$destination->path)) {
$message = sprintf(__(‘Unable to write to directory %s. Is this directory writable by the server?’, ‘nggallery’), WINABSPATH.$destination->path);
nggGallery::show_error($message);
return;
}

// Get pictures
$images = nggdb::find_images_in_list($pic_ids);
$destination_path = WINABSPATH . $destination->path;

foreach ($images as $image) {
// WPMU action
if ( nggAdmin::check_quota() )
return;

$i = 0;
$tmp_prefix = ”;
$destination_file_name = $image->filename;
while (file_exists($destination_path . ‘/’ . $destination_file_name)) {
$tmp_prefix = ‘copy_’ . ($i++) . ‘_’;
$destination_file_name = $tmp_prefix . $image->filename;
}

$destination_file_path = $destination_path . ‘/’ . $destination_file_name;
$destination_thumb_file_path = $destination_path . ‘/’ . $image->thumbFolder . $image->thumbPrefix . $destination_file_name;

// Copy files
if ( !@copy($image->imagePath, $destination_file_path) ) {
$errors .= sprintf(__(‘Failed to copy image %1$s to %2$s’,’nggallery’),
$image->filename, $destination_file_path) . ”;
continue;
}

// Copy the thumbnail if possible
!@copy($image->thumbPath, $destination_thumb_file_path);

// Create new database entry for the image
$new_pid = nggdb::insert_image( $destination->gid, $destination_file_name, $image->alttext, $image->description, $image->exclude);

if (!isset($new_pid)) {
$errors .= sprintf(__(‘Failed to copy database row for picture %s’,’nggallery’), $image->pid) . ”;
continue;
}

// Copy tags
nggTags::copy_tags($image->pid, $new_pid);

if ( $tmp_prefix != ” ) {
$messages .= sprintf(__(‘Image %1$s (%2$s) copied as image %3$s (%4$s) » The file already existed in the destination gallery.’,’nggallery’),
$image->pid, $image->filename, $new_pid, $destination_file_name) . ”;
} else {
$messages .= sprintf(__(‘Image %1$s (%2$s) copied as image %3$s (%4$s)’,’nggallery’),
$image->pid, $image->filename, $new_pid, $destination_file_name) . ”;
}

/* by M.C. – Added Lines – Copy Custom Fields Too! */
/* NextGEN Custom Fields Patch */
if ( function_exists ( ‘nggcf_save_pics’ ) )
{
global $wpdb;

if ( $mcRecords = $wpdb -> get_results ( “SELECT * FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=1 AND pid = ” . $image -> pid ) )
{
foreach ( $mcRecords as $mcRecord )
$wpdb -> query ( “INSERT INTO ” . $wpdb->prefix . “nggcf_field_values ( id,pid,fid,field_value,dateadded,ngg_type ) VALUES ( null,’$new_pid’,'” . $mcRecord -> fid . “‘,'” . $wpdb-> escape ( $mcRecord -> field_value ) . “‘, ‘” . date ( “Y-m-d H:i:s”,time () ) . “‘, ‘” . $mcRecord -> ngg_type . “‘)” );
}
}
/* NextGEN Custom Fields Patch */
/* by M.C. – Added Lines – Copy Custom Fields Too! */

}

// Finish by showing errors or success
if ( $errors == ” ) {
$link = ‘gid . ‘” >’ . $destination->title . ‘‘;
$messages .= ‘<hr />’ . sprintf(__(‘Copied %1$s picture(s) to gallery: %2$s .’,’nggallery’), count($images), $link);
}

if ( $messages != ” )
nggGallery::show_message($messages);

if ( $errors != ” )
nggGallery::show_error($errors);

return;
}

file: admin/manage.php – function processor

function processor() {

global $wpdb, $ngg, $nggdb;

// Delete a gallery
if ($this->mode == ‘delete’) {

check_admin_referer(‘ngg_editgallery’);

// get the path to the gallery
$gallerypath = $wpdb->get_var(“SELECT path FROM $wpdb->nggallery WHERE gid = ‘$this->gid’ “);
if ($gallerypath){

// delete pictures
//TODO:Remove also Tag reference, look here for ids instead filename
$imagelist = $wpdb->get_col(“SELECT filename FROM $wpdb->nggpictures WHERE galleryid = ‘$this->gid’ “);
if ($ngg->options[‘deleteImg’]) {
if (is_array($imagelist)) {
foreach ($imagelist as $filename) {
@unlink(WINABSPATH . $gallerypath . ‘/thumbs/thumbs_’ . $filename);
@unlink(WINABSPATH . $gallerypath .’/’. $filename);
}
}
// delete folder
@rmdir( WINABSPATH . $gallerypath . ‘/thumbs’ );
@rmdir( WINABSPATH . $gallerypath );
}
}

/* by M.C. – Added Lines – Delete Custom Fields Too! */
/* NextGEN Custom Fields Patch */
if ( function_exists ( ‘nggcf_save_pics’ ) )
{
if ( $mcRecords = $wpdb -> get_results ( “SELECT * FROM ” . $wpdb -> nggpictures. ” WHERE galleryid = ” . $this -> gid ) )
{
foreach ( $mcRecords as $mcRecord )
$wpdb -> query ( “DELETE FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=1 AND pid = ” . $mcRecord -> pid );
}
$wpdb -> query ( “DELETE FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=2 AND pid = ” . $this -> gid );
}
/* NextGEN Custom Fields Patch */
/* by M.C. – Added Lines – Delete Custom Fields Too! */

$delete_pic = $wpdb->query(“DELETE FROM $wpdb->nggpictures WHERE galleryid = $this->gid”);
$delete_galllery = $wpdb->query(“DELETE FROM $wpdb->nggallery WHERE gid = $this->gid”);

if($delete_galllery)
nggGallery::show_message( _n( ‘Gallery’, ‘Galleries’, 1, ‘nggallery’ ) . ‘ \”.$this->gid.’\’ ‘.__(‘deleted successfully’,’nggallery’));

$this->mode = ‘main’; // show mainpage
}

// Delete a picture
if ($this->mode == ‘delpic’) {
//TODO:Remove also Tag reference
check_admin_referer(‘ngg_delpicture’);
$image = $nggdb->find_image( $this->pid );
if ($image) {
if ($ngg->options[‘deleteImg’]) {
@unlink($image->imagePath);
@unlink($image->thumbPath);
}
$delete_pic = $wpdb->query(“DELETE FROM $wpdb->nggpictures WHERE pid = $image->pid”);

/* by M.C. – Added Lines – Delete Custom Fields Too! */
/* NextGEN Custom Fields Patch */
if ( $delete_pic )
{
if ( function_exists ( ‘nggcf_save_pics’ ) )
$wpdb -> query ( “DELETE FROM ” . $wpdb -> prefix . “nggcf_field_values WHERE ngg_type=1 AND pid = ” . $image -> pid );
}
/* NextGEN Custom Fields Patch */
/* by M.C. – Added Lines – Delete Custom Fields Too! */

}
if($delete_pic)
nggGallery::show_message( __(‘Picture’,’nggallery’).’ \”.$this->pid.’\’ ‘.__(‘deleted successfully’,’nggallery’) );

$this->mode = ‘edit’; // show pictures
}

// will be called after a ajax operation
if (isset ($_POST[‘ajax_callback’])) {
if ($_POST[‘ajax_callback’] == 1)
nggGallery::show_message(__(‘Operation successful. Please clear your browser cache.’,”nggallery”));
}

// show sort order
if ( isset ($_POST[‘sortGallery’]) )
$this->mode = ‘sort’;

if ( isset ($_GET[‘s’]) )
$this->search_images();

}