Multiple Missing Closing Tags in Markup

  • Resolved maxxskywalker

    (@maxxskywalker)


    5 years, 2 months ago

    I’ve noticed your plugin has missing closing anchor tags, within the “recentlyviewed_left” containers, in all of your loop items. After breaking down your shortcode’s markup I’ve found that all of the loop items are reflecting this mistake, messing up any other containers that come after it. You are also missing a closing unordered list tag, and a closing div tag as well.

    My workaround, at this point in time, has been to apply a closing div right after your shortcode so that the rest of my own markup is not affected by your development team’s oversight — I shouldn’t have to do this.

    Please review your markup and update your plugin. I’d rather not have to utilize a different plugin if I don’t have to, but I can’t rollout into production with oversights that stick out this bad.

    Attached is the markup breakdown that has been unaltered from the output, aside from a couple comments and whitespacing cleanup so you can clearly see your missing tags.

    https://drive.google.com/open?id=1MU9AI-7tP4jmsi-XIcTk-HTi4maAJVXI

    The page I need help with: [log in to see the link]

Viewing 9 replies - 16 through 24 (of 24 total)
  • Plugin Author Amit Sonkhiya

    (@amitaits)

    Hello @maxxskywalker

    Please create a separate and simple stagging WP site with any WordPress default theme to find the concern and further rectify it.
    I’m not able to see the plugin generated markup on the given site as it was appearing in the past.
    I couldn’t find any issue at my development server or other installations.

    Thanks

    Thread Starter maxxskywalker

    (@maxxskywalker)

    Well, I guess this is where I lose your support. I started up a clean WordPress installation with just Divi, WooCommerce, and your plugin installed, as you suggested.

    I created four products, visited each one, and then placed the widget shortcode in an empty page. As you can see in the screenshot below, the closing unordered list and div tags are generated.

    https://drive.google.com/file/d/1MU9AI-7tP4jmsi-XIcTk-HTi4maAJVXI/view?usp=sharing

    I don’t know what’s going on, with the site I’m currently working on, for it to not have those tags generated, but I guess the onus is on me to figure what’s conflicting with your plugin for that to occur.

    I did notice that as I visited various products, that the closing tags did generate, along with the number of products counter I placed in there upon your request, up until I hit the display limit that I imposed in the widget’s settings.

    Thanks for taking the time to try and help me out, though.

    Thread Starter maxxskywalker

    (@maxxskywalker)

    It only fails to output the closing unordered list and div tags if I hit, or exceed, the limit imposed in the widget’s settings. If I increase the limit to five and have only visited four products, the closing tags will generate, but if I reduce it to three, the closing tags disappear.

    I went back to https://equipment.almost.online, and disabled all the plugins, besides yours and WooCommerce, installed the Twenty Nineteen theme, and put your shortcode into a page. With the limit set to 4 in the widget, I visited the page and noticed that the closing unordered list and div tags were gone. I put the shortcode on this page: https://equipment.almost.online/test

    So we have one test case where the plugin’s working properly (https://test.almost.online), but in the other, even though everything has been disabled, with transients and caches having been cleared, I still encounter the issue. It should be noted that these two staging environments are hosted on the same server with PHP 7.2 installed.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    @maxxskywalker

    Please do one thing and let me know the result.

    At line number 150 in the recent_viewed_post.php file, there is a return statement. Replace it with break and do let me know.

    Replace
    return;
    to
    break;

    Thread Starter maxxskywalker

    (@maxxskywalker)

    Thanks for putting up with me as long as you have, Amit. This seems to have fixed the problem.

    https://drive.google.com/open?id=1MU9AI-7tP4jmsi-XIcTk-HTi4maAJVXI

    Plugin Author Amit Sonkhiya

    (@amitaits)

    Hello @maxxskywalker

    You’re welcome. Please try with manipulating the number of posts to show. If this seems working as expected, I will release an updated version.

    Thread Starter maxxskywalker

    (@maxxskywalker)

    I changed the limit to various values (1, 2, 3, 4, 5, 6, and 8) and it was working consistently, without losing the closing unordered list and div tags.

    Thanks again.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    @maxxskywalker

    We’ve released version 1.3.2 of the plugin. It will fix the said issue.

    Thanks

    Thread Starter maxxskywalker

    (@maxxskywalker)

    Thank you so much for taking the time to fix this for me. I really appreciate it.

Viewing 9 replies - 16 through 24 (of 24 total)
  • The topic ‘Multiple Missing Closing Tags in Markup’ is closed to new replies.