multiple backups?

Yes, that is a good test because turning off “Compress Backup Files” also makes the bug which I found in the backup code irrelevant …
Also I’m still interested in the size of the resulting .sql file.
(This way I get an idea of how big the backup actually is).

dwinden

after 1 day this is the situation
https://www.diigo.com/item/image/51ynl/mead
(when I opened this thread in that directory I had ~30 .zip and .sql files)
not sure what’s changed, but it looks it works SO LONG.
I’ll update you tomorrow, if I’ll find just 1 .SQL file it works (if itheme security deletes the old one).

and that’s the current situation…
https://www.diigo.com/item/image/51ynl/a264
what’s wrong here :/

That doesn’t look good …
Did you disable “Compress Backup Files” ?
Verify “Compress Backup Files” setting in the database like this:
Login to the database using phpMyAdmin and then execute the following
SQL command:

select * from [prefix]options where option_name = ‘itsec_backup’;

(where [prefix] must be substituted with your table prefix).

If “Compress Backup Files” is enabled “zip” is 1:
s:3:”zip”;b:1;

If “Compress Backup Files” is disabled “zip” is 0:
s:3:”zip”;b:0;

I’m assuming you did not disable “Compress Backup Files” since I still see new .zip files created.
The .sql files are probably not deleted because there is a bug in the backup code when “Compress Backup Files” is enabled.

When the .zip file creation fails it is not handled by the backup code.
That is also why we have no further info\error why zipping fails.

Not sure whether zip file failing causes multiple backup attempts. Could be multiple issues …

Rethinking our strategy to solve this …

dwinden

uhm, as I said to you I disabled compression, but not sure why, just right now I found the option enabled (but maybe I’ve just clicked on the “save changes button” related to another tab last time, not sure it’s the same ?? ). Now I disabled correctly the option.
I will let you know what’s happen.

thanks

Ok, don’t worry it happened to me once too …

dwinden

that’s what I have now, I guess it finally works
https://www.diigo.com/item/image/51ynl/0i9e

With other files I mean the images and the scripts, why the backup saves just the db? what about the other file? ??

Ok, great exactly what we expected.

So this basically confirms there seems to be an issue zipping in your env.
If you wish you can use the following code\script to try and get info on the zip failing:

<?php
define( 'ABSPATH', dirname(__FILE__) . '/' );
require( ABSPATH . 'wp-admin/includes/class-pclzip.php' );
$zip = new PclZip( ABSPATH . 'wp-content/uploads/ithemes-security/backups/whatever.zip' );

if (($v_result_list = $zip->create( ABSPATH . 'wp-content/uploads/ithemes-security/backups/whatever.sql' )) !== 0 ) {
	echo 'Zip file created successfully.<BR>';
	echo "<pre>";
	var_dump($v_result_list);
	echo "</pre>";
	//unlink( ABSPATH . 'wp-content/uploads/ithemes-security/backups/whatever.sql' );
}
else {
	echo 'Zip failed !<BR>';
	echo "Error : ".$zip->errorInfo(true);
}
?>

Simply put a .php file with the code above in the wordpress root, make some minor changes in the code and then call it from the browser.

Replace “whatever” (2x) with the name of an existing .sql file and you are all set. I have commented the unlink command that would normally delete the .sql file. Leave it that way to keep the .sql file.

dwinden

a sql it’s enough I don’t need necessarily a zip ??
thanks

I understand.

But it would help the community when we actually get an error of the .zip file creation failing. I’ve seen many people reporting the same issue in this forum …

To solve the issue we can now only advise people to disable the “Compress Backup Files” option. That’s not a solution but a workaround.

So please help me to get to the bottom of this.
It’s a quick test … make the test script and run it …that’s all.
It is all about the error message when zip file creation fails …

dwinden

more that happy to help.
But that’s the result:

Zip file created successfully.
array(1) {
  [0]=>
  array(10) {
    ["filename"]=>
    string(71) "/membri/mysite/wp-content/uploads/ithemes-security/backups/asc.sql"
    ["stored_filename"]=>
    string(71) "/membri/mysite/wp-content/uploads/ithemes-security/backups/asc.sql"
    ["size"]=>
    int(246060)
    ["compressed_size"]=>
    int(36638)
    ["mtime"]=>
    int(1422910075)
    ["comment"]=>
    string(0) ""
    ["folder"]=>
    bool(false)
    ["index"]=>
    int(-1)
    ["status"]=>
    string(2) "ok"
    ["crc"]=>
    int(2121487303)
  }
}

I tried a little sql dump (200kb) and my site sql dump (~35MB) both..it works..

Ok, great.

Not the result I expected but at least we have tried.
I won’t take this any further. I’m sure there are other priorities.

Something else …
I think I already answered your question “With other files I mean the images and the scripts, why the backup saves just the db? what about the other file?” earlier in this topic but let me explain a little bit further:

The iTSec plugin indeed only makes a backup of the DB.
But iThemes has another backup product named BackupBuddy which is specially designed for backing up all the site files.
I think iThemes is using the free iTSec plugin to sell other software products like BackupBuddy …

Time to mark this topic as ‘resolved’.

Thank you for your help.

dwinden

thanks to you! so you aren’t a ithemes developer?

No, I’m not …
Just keeping my skills up to date … for fun ??

dwinden

well very thanks way more then!

(anyway i’m not sure I have to mark this as solved, my issue with zip compression isn’t actually solved..)