Moving custom post types under the settings menu (revisted)

Hi,

From the given information, I cannot reproduce the problem and I’m not able to know what the addressed issue is yet.

So can you create a very simple plugin that only demonstrates the problem? Something like having only an admin class that adds a page and a post type that belongs to that admin page menu.

And Gist may be a good place to post code.

Thank you.

Good idea. Here’s a Gist of the simplified plugin:

https://gist.github.com/davidgewirtz/617ff709c0c83c1f9efb

There’s a bunch of comments at the beginning that explain my questions, but for completeness, here they are as well:

Here’s what I’m trying to do. I want to have custom post types that can either be separate, on their own in the dashboard menu, or tucked into the main menu. This constant controls that option. When COMPACT_MENUS is false, the menus live in the dashboard. When COMPACT_MENUS is true, they should tuck into the For Michael menu.

It should be noted that in the real plugin, I don’t use a constant for COMPACT_MENUS, but a WordPress option.

Note on line 140 that the COMPACT_MENUS constant changes whether the menu items show on the main dashboard or under the menu. I am not sure this is done correctly, because with more items, the dashboard doesn’t display properly. Please review my code in this area.

If COMPACT_MENUS is true, I would like to be able to add a tab to the current two tabs, and put the content of the custom post type in that tab. I would also like to control where in the row of tabs the new tab is displayed. That code is not shown here because I don’t know how to do it.

The admin class is set up in the on line 37
The custom post type is created on line 112
The tabs are created on line 238

David,

the dashboard sidebar menu gets very strange (as in menu items move when the mouse rolls over them, the whole thing acts like its been corrupted and doesn’t know that items aren’t there).

By trying the sample plugin posted above, I don’t get this problem. It can be your JavaScript scripts or CSS rules causing it. I see you loading your CSS file adminstyles.css in the above demo, which is not accessible for me. So you may try unloading all your custom JavaScript and CSS files to see if the menu gets displayed properly.

I’ll try that. When I simplified the plugin down to one custom post type instead of three, the problem went away. But, of course, my plugin has three. Did my code around the definition of the custom post type (especially where I optionally add the array elements for COMPACT_MENUS) look like what you would expect? Are there any other attributes I should add or remove?

Now, given this example, what about this part. You gave me a rough explanation once, but I was hoping that with this example, you might be able to me more specific (since I didn’t get that approach to work):

If COMPACT_MENUS is true, I would like to be able to add a tab to the current two tabs, and put the content of the custom post type in that tab. I would also like to control where in the row of tabs the new tab is displayed. That code is not shown here because I don’t know how to do it.

Thanks!

Michael, one of my users also graciously mocked up an image showing the two variations of what I’m trying to accomplish:

https://no3x.de/web/wp-content/uploads/2015/09/Seamless-Donations-Condensed-Menu.png

Thanks!

David,

But, of course, my plugin has three. Did my code around the definition of the custom post type (especially where I optionally add the array elements for COMPACT_MENUS) look like what you would expect? Are there any other attributes I should add or remove?

You may add more sample post types to the test plugin and you’ll see the number of added post types is not relevant.

My suggestion is the same. Try unloading your custom JavaScript and CSS files to see if the problem persists.

As for the second question, let’s solve the first issue first.

Michael, one of my users pointed this article out:

https://wptavern.com/a-bug-in-chrome-45-causes-wordpress-admin-menu-to-break

It seemed to solve the weird admin menu problem. So I’d appreciate it if you could move onto the second phase, which would be tucking the CPT items themselves into the set of tabs provided.

Thanks!

You may add more page heading tab items like this in the setUp() method.

$this->addSubMenuItems(
            array(
                'title' => __( 'Funds', 'your-text-domain-here' ),
                'href'  => add_query_arg(
                    array(
                        'post_type' => 'funds', // sets the post type slug here
                    ),
                    admin_url( 'edit.php' )
                ),
                'show_in_menu'  => false,
                'order'         => 1, // e.g. 5, 20, 100
            ),
            array(
                // add another one here
            )
        );

That’s pretty slick, but it uses the tab to redirect to the Funds page. Is there a way to put the entire funds CPT interface under the tab?

Thanks!

Technically redirect is something done in the HTTP header. A tab item created by the framework is just a link.

Moving the entire output of a custom post type page may require iframe or ajax and the framework does support it.

However, by inserting your custom navigation tabs into all the pages, you can let the user feel as if the custom post type page is in the tab. I’ve written an example plugin before. https://gist.github.com/michaeluno/9cc296a0b70114f26586

Closing the topic due to inactivity.