Modals not working in 1.5
-
I can confirm modals are still not working in 1.5.03 – at least not for me.
In 1.4.91 everything is fine.
-
I’m not able to reproduce this. Can you tell me which modal shortcode you are using and if you have any JavaScript console errors please?
I’m happy to help, but until I can reproduce this, I can’t fix it.
Rollback to 1.4.9.1 fixed it for me. Note that for me 1.5.0.3 still has missing files etc. or whatever it is. I also had tried it with the master version from git, same problem. Hope it helps.
I think I see the problem in 1.5.0.3, and its not present in 1.5.0.4-b-1 (https://github.com/CalderaWP/Caldera-Forms/releases/tag/1.5.0.4-b-1) so I think we got this one under control.
Again, 1.5 was a MAJOR release. Testing on a staging server for new major releases is always the best idea.
Sorry, because of the weekend it took a bit longer to get back to you on this.
This is from the Javascript console on Chrome. The first two are present if I load a page with a Caldera shortcode, the last one appears after I click the button. Probably more than you need…
GET https://[xxx]/wp-content/plugins/caldera-forms/assets/build/js/vue/vue-filter.min.js 404 (Not Found)
send @ jquery.js?ver=1.12.4:4
ajax @ jquery.js?ver=1.12.4:4
n._evalUrl @ jquery.js?ver=1.12.4:4
Ha @ jquery.js?ver=1.12.4:3
append @ jquery.js?ver=1.12.4:3
(anonymous) @ formobject.min.js?ver=1.5.0.3:1
(anonymous) @ formobject.min.js?ver=1.5.0.3:1Uncaught SyntaxError: Unexpected token <
at eval (<anonymous>)
at jquery.js?ver=1.12.4:2
at Function.globalEval (jquery.js?ver=1.12.4:2)
at text script (jquery.js?ver=1.12.4:4)
at Xb (jquery.js?ver=1.12.4:4)
at y (jquery.js?ver=1.12.4:4)
at c (jquery.js?ver=1.12.4:4)
at Object.send (jquery.js?ver=1.12.4:4)
at Function.ajax (jquery.js?ver=1.12.4:4)
at Function.n._evalUrl (jquery.js?ver=1.12.4:4)
(anonymous) @ jquery.js?ver=1.12.4:2
globalEval @ jquery.js?ver=1.12.4:2
text script @ jquery.js?ver=1.12.4:4
Xb @ jquery.js?ver=1.12.4:4
y @ jquery.js?ver=1.12.4:4
c @ jquery.js?ver=1.12.4:4
send @ jquery.js?ver=1.12.4:4
ajax @ jquery.js?ver=1.12.4:4
n._evalUrl @ jquery.js?ver=1.12.4:4
Ha @ jquery.js?ver=1.12.4:3
append @ jquery.js?ver=1.12.4:3
(anonymous) @ formobject.min.js?ver=1.5.0.3:1
(anonymous) @ formobject.min.js?ver=1.5.0.3:1Uncaught TypeError: Cannot read property ‘open’ of undefined
at HTMLButtonElement.eval (eval at <anonymous> (jquery.js?ver=1.12.4:2), <anonymous>:1:7215)
at HTMLDocument.dispatch (jquery.js?ver=1.12.4:3)
at HTMLDocument.r.handle (jquery.js?ver=1.12.4:3)
(anonymous) @ VM160:1
dispatch @ jquery.js?ver=1.12.4:3
r.handle @ jquery.js?ver=1.12.4:3I observed the same issue with vue-filter.min.js. I’ll stick with the 1.4.9 in production for now until I can figure how to deal with it. No stress ??
1.5.0.4-b-1 fixed the issue for me. Great! Happy about the new fields too! ??
I noticed that I did get a small error though:
Uncaught ReferenceError: Parsley is not defined at nl.js?ver=1.5.0.4:4 (anonymous) @ nl.js?ver=1.5.0.4:4
// Validation errors messages for Parsley // Load this after Parsley Parsley.addMessages('nl', { defaultMessage: "Deze waarde lijkt onjuist.", type: { email: "Dit lijkt geen geldig e-mail adres te zijn.", url: "Dit lijkt geen geldige URL te zijn.", number: "Deze waarde moet een nummer zijn.", integer: "Deze waarde moet een nummer zijn.", digits: "Deze waarde moet numeriek zijn.", alphanum: "Deze waarde moet alfanumeriek zijn." }, notblank: "Deze waarde mag niet leeg zijn.", required: "Dit veld is verplicht.", pattern: "Deze waarde lijkt onjuist te zijn.", min: "Deze waarde mag niet lager zijn dan %s.", max: "Deze waarde mag niet groter zijn dan %s.", range: "Deze waarde moet tussen %s en %s liggen.", minlength: "Deze tekst is te kort. Deze moet uit minimaal %s karakters bestaan.", maxlength: "Deze waarde is te lang. Deze mag maximaal %s karakters lang zijn.", length: "Deze waarde moet tussen %s en %s karakters lang zijn.", equalto: "Deze waardes moeten identiek zijn." }); Parsley.setLocale('nl');
Cheers! ??
Modals are working for me again as well – but only if I disable the Autoptimize plugin, that minifies JS.
@sanderpinkse; what JS errors do you see on the browser console when AO’s JS optimization is active?
This is what I’m seeing with JS optimization on:
Uncaught ReferenceError: Parsley is not defined
at autoptimize_5d5952f….js:321
(anonymous) @ autoptimize_5d5952f….js:321And this when I turn it off:
Uncaught ReferenceError: Parsley is not defined
at nl.js?ver=1.5.0.4:4
(anonymous) @ nl.js?ver=1.5.0.4:4In the first case the Caldera modals are not working, in the second case they are…
Cheers!
ok, so the root problem is that
Parsley is not defined error
in Caldera-forms which blocks the executions of everything after that when optimized (also referenced by @soulretriever above).best solution; caldera forms fixes this
workaround; addnl.js
to AO’s JS optimization exclusion listgroetjes,
frank (ao dev)
- The topic ‘Modals not working in 1.5’ is closed to new replies.