Mixed Units Issue

  • Resolved swerley

    (@swerley)


    3 years, 2 months ago

    Greetings Sky Bolt and Connect Think,

    My team and I are long-time users of this exceptional plugin and appreciate all of your hard work to maintain it. WP-SCSS has been a core component of our workflow for the past four years and has helped improve our WordPress projects and deliverables in countless ways. From ourselves and the greater community, thank you so much for continuing to keep this plugin updated and alive!

    I am writing today to mention an unexpected issue we’ve been running into with the 2.3.X versions of the plugin. We’ve been testing these latest releases on a dev site (a clone of our master template site that we actively maintain for new projects). We’re running into a particular issue that didn’t exist in WP-SCSS v2.1.6 and earlier which has become a pain point for us.

    On more than 150 of our client websites using WP-SCSS, we have been importing a partial file that includes all of our predefined breakpoints mixins to simplify our workflow. After upgrading to 2.3.X versions of WP-SCSS (the latest being 2.3.5 as of writing this post), WP-SCSS is throwing the following sass compiling error message regarding mixed units in mixins: https://rzfg.co/D4zgPS.

    Within our foundation partial file, our breakpoints mixins are set using a combination of rem and px units for media queries as seen here: https://rzfg.co/oeqkpu.

    After revising units to be rem only, the media queries now look like this: https://rzfg.co/q2fsxN. The WP-SCSS sass compiling error message disappears entirely and there are no further problems.

    Would it be possible to continue including support for mixed units in future versions of WP-SCSS? Updating each of our sites individually, in a similar manner to the example above, is not ideal and would take an incredible amount of time to resolve for our small firm of three.

    For the time being, we have no other choice but to continue using an outdated version of the plugin that supports mixed units, which is not a viable long-term strategy. We cannot afford to have all of our sites break if updated to the latest version.

    Our team would appreciate learning more about the decision behind this change, and if supporting mixed units is perhaps an outdated practice that should be avoided altogether.

    Thanks so much for your time and energy. We look forward to hearing back from you.

    With gratitude,

    Swerley

    • This topic was modified 3 years, 2 months ago by swerley.
    • This topic was modified 3 years, 2 months ago by swerley.
Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Sky Bolt

    (@sky-bolt)

    Hi @swerley, thank you for the write up and gratitude on the plugin.
    First off let me explain why the change occured. It is due to the upgrade of WP-SCSS to use a newer version of SCSSPHP which is at the core of WP-SCSS plugin. My goal is to keep the plugin updated with the latest version of SCSSPHP going forward. Now that I look this plugin is a couple versions behind of SCSSPHP. If your issue has been fixed between 1.5.2 and 1.8.1 the next time I update SCSSPHP it would allow you to continue as you currently are doing it.

    My personal recommendation would be todo the work up updating your media file. Then distributing that to the rest of your websites. I had thought you would be able to use calc() which can handle the mixed units, but that won’t work in media queries.

    Thread Starter swerley

    (@swerley)

    Hi @sky-bolt,

    I am grateful for your follow-up and your explanation regarding keeping the plugin updated with the latest version of SCSSPHP. This makes more sense now.

    We’ve gone ahead and updated the mixins on all of our sites to use compatible units as shown in my provided example. This has removed the error message we were experiencing.

    Thank you again for continuing to support this wonderful plugin!

    Kind regards,

    Swerley

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Mixed Units Issue’ is closed to new replies.