Missing strings for translation

  • Resolved KHannibal

    (@khannibal)


    9 years, 7 months ago

    Hi guys,

    First of all I’d like to thank Anders for this theme, it’s really awesome and beautiful. Amazing job !

    I’ve found that there are some strings that are missing. Seems they are “lost in translation”. ??

    For example, “Leave a Reply” isn’t translatable. Is there a way I can fix that via a child theme or by adding something in the .po file ?

    I’ve seen that pixelverbieger made a post and a child theme for a german translation with a few other fixes, I’m currently translating Rowling into French.

    Thanks for your help !

    Cheers,

    K

Viewing 5 replies - 1 through 5 (of 5 total)

  • look at comments.php, lines 98 and 101
    you will see twice

    _(Leave ...

    this prevents the strings from being recognized by poedit; just add a second underscore and you’re done.

    __('Leave ...

    btw, this change is included in my child’s comments.php

    … same in the file content.php:

    comments_popup_link( '0 Comments', '1 Comment', '% Comments');

    is not translatable; if you change it to

    comments_popup_link(
'0 ' . __('Comments', 'rowling'),
'1 ' . __('Comment', 'rowling'),
'% ' . __('Comments', 'rowling')
);

    it will ??

    Thread Starter KHannibal

    (@khannibal)

    Thank you for your answer, it worked like a charm. ??

    I didn’t check if you fixed that also in your child theme, but there is a singular/plural mistake in single.php (main theme) at line 29 :

    '<span class="fa fw fa-comment"></span>0<span class="resp"> ' . __('Comments', 'rowling') . '</span>',

    should be

    '<span class="fa fw fa-comment"></span>0<span class="resp"> ' . __('Comment', 'rowling') . '</span>',

    So far, that’s all I’ve found. ??

    Glad I could help!

    Concerning your finding in line 29… this ain’t a mistake, I think.
    It is correct to say “we have no comment”, as well as “we have no comments” – but with digits it is always “we have zero comments”; there must be (or better: stay) plural.

    Thread Starter KHannibal

    (@khannibal)

    In french, zero goes with singular, that’s why I had to change that. ??

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Missing strings for translation’ is closed to new replies.