Missing semicolon after defining variable hbspt.enqueueForm

  • Resolved Scott Trsar

    (@scotttrsar)


    3 years, 3 months ago

    Please fix omitted semicolon on line 194 in src/class-pagehooks.php. Causes expression errors if minifying inline JS when conditional following is on the same line.

    Thank you!

    truck:

    hbspt.enqueueForm = function(formDef) {
	if (hbspt.forms && hbspt.forms.create) {
		hbspt.forms.create(formDef);
	} else {
		hbspt._wpFormsQueue.push(formDef);
	}
}

    requested update:

    hbspt.enqueueForm = function(formDef) {
	if (hbspt.forms && hbspt.forms.create) {
		hbspt.forms.create(formDef);
	} else {
		hbspt._wpFormsQueue.push(formDef);
	}
};

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support cheffernan

    (@cheffernan)

    Hi Scott,

    Thank you for the suggestion. We can add this semi colon / it will be in the next release. I will follow up here when we update.

    Best,
    Conor

    Thread Starter Scott Trsar

    (@scotttrsar)

    You’re the man Conor!

    Appreciate the quick response.

    I will note this moment as one of the first times I didn’t get push back from a plugin developer about a minor change. Glad I didn’t need to disable all other plugins and switch to the default theme : )

    Thanks again, Conor!

    • This reply was modified 3 years, 3 months ago by Scott Trsar.
    • This reply was modified 3 years, 3 months ago by Scott Trsar.
    Plugin Support cheffernan

    (@cheffernan)

    Hi @scotttrsar,

    Very happy we were able to help you out. Glad to hear also that we are one of the more accommodating development teams on the WordPress plugin store ??

    If you are enjoying the plugin, and you do have a moment to spare, it would mean an awful lot to us if you could leave a review.

    We are deploying the new version of the plugin right now so you should be able to update to a version with your requested change. Let me know if you have any other issues.

    Best,
    Conor

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Missing semicolon after defining variable hbspt.enqueueForm’ is closed to new replies.

Tags