Missing Popup Close Image (replaced with dashicon)

  • Resolved Pat K

    (@blackcapdesign)


    6 years, 5 months ago

    Hi Joe,
    I just updated a site using My Calendar from v2.5.17 to 3.0.5 and noticed the close button was missing in the event popups. On closer inspection I could see the button is there, but it’s no longer an image…it’s now a dashicon (with white font-color on a white background).

    I totally get the rationale for doing this, but it seems odd to do this in a way that breaks all sites out there using event popups. Perhaps I’m missing something?

    I would have thought the default would continue to be the close image with the option to use a dashicon.

    Is my only option to update the stylesheet for all sites using My Calendar event popups; specifying default and hover state font-color for the dashicon? Have you made this change in other places people should be aware of?

    Thanks!

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Joe Dolson

    (@joedolson)

    Most likely, the icon is white because something else is setting that color and overriding My Calendar’s settings. Can you share a URL?

    Thread Starter Pat K

    (@blackcapdesign)

    Thanks Joe,
    I didn’t have ample time to troubleshoot, so I rolled it back to v2.5.17, so sharing a link wouldn’t do any good. I’ll run the update again when I have time and will report back. Thanks for the CSS tip.

    Any thought on why the code is different in the new version. v2.5.17 shows an image icon; v3.0.5 showed a dashicon and no image (as the close button). Is that structural change part of the version 3 modifications?
    PK

    Plugin Author Joe Dolson

    (@joedolson)

    Yes, that’s one of the many changes in version 3.0.

    You can still use custom code to use an image, if you wish, using the same custom pattern you could before: https://github.com/joedolson/plugin-extensions/blob/master/my-calendar/mc-close-button.php

    Plugin Author Joe Dolson

    (@joedolson)

    This should render more correctly by default using 3.0.6.

    Thread Starter Pat K

    (@blackcapdesign)

    Thanks for that Joe. I ran the update and the popup and invisible close button renders the same as it did in v3.0.5. I haven’t had time to troubleshoot this yet but as soon as know why it’s doing this, I’ll report back.

    Plugin Author Joe Dolson

    (@joedolson)

    It still could be overridden by your theme or other plugins.

    @joedolson. after troubleshooting this myself (as mentioned on the thread regarding pop-up not launching), i noticed that specifying “font-family: dashicons” for the CSS “.mc-toggle.close span:before” will make the dismiss icon appear.

    @blackcapdesign you could have a try by adding the above CSS into your theme’s file.

    Thread Starter Pat K

    (@blackcapdesign)

    Hi Joe,
    Quick follow up on this. I finally found time to update and fix the missing event popup close icon.

    I have My Calendar installed on 3+ sites. On one, after the update, the dashicon showed up fine in red (parent theme Twenty Fourteen). On two others, (different parent themes: GeneratePress and Genesis) the icon was not visible (white font-color on a white background).

    In all 3 cases the rule is set in my-calendar/reset.css with the following ruleset:
    button.mc-toggle {
    color: #a00 !important;
    }

    But on 2 of the sites, the ruleset (oddly) was being overruled by the default button color (white) despite your !important declaration.

    I added the following to the child theme style.css file and the buttons are showing on both sites now:
    .dashicons-dismiss:before {
    color: black;
    font-size: 1.2em;
    }

    Hopefully this will help someone else whose close buttons have gone “missing”.

    Cheers, …and thanks Kilzac for the suggestion!
    PK

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Missing Popup Close Image (replaced with dashicon)’ is closed to new replies.