Well, this was a real eye-opener.
First off, I discovered I am using a non-existent hook after_theme_setup
for my add_theme_support
call. The correct hook is after_setup_theme
. In effect, whether testimonials had thumbnails was determined by the theme and/or other plugins.
The fact that it has not come up until now is probably due to most themes calling add_theme_support( 'post-thumbnails' )
without arguments (like TwentyFifteen does) which enables thumbnails for all post types, including any created by plugins.
Calling it with arguments saves, not appends, the arguments, as you mentioned. Subsequent calls will overwrite, and the last one wins. And the order seems to alphabetical: The Hemingway theme would be loaded before Strong Testimonials; Strong would be loaded before TwentyFifteen.
The Codex does not mention this. It’s not really a bug but it’s not intuitive behavior either.
So if my plugin had the correct hook, it may have disabled thumbnails for posts, etc. for any theme/plugin starting with A-R and the problem would have been discovered a long time ago. Wow :/
I have a fix that I need to test thoroughly using the correct hook and that properly appends “wpm-testimonial” to the existing post types, unless it’s already global. That does not solve the alphabetical order issue though.
In the meanwhile, add “wpm-testimonial” to your list and it should work.
Thanks for your persistence.