Missing Dependencies

  • Resolved Vijay Hardaha

    (@vijayhardaha)


    3 years ago

    Missing Dependencies of “revolut-core” on “revolut-woocommerce”
    This error in all the pages except the checkout page as the “revolut-core” is not registered for the checkout and some specific pages while “revolut-woocommerce” is registered in all pages.

    https://ibb.co/dgGSXVL

    I also find some duplicate functions. e.g. createApi function this function is in the abstract class and this function also is in the gateway-revolut.php file as a global function.

    and class-wc-gateway-revolut.php also have this function and I found this file is not called anywhere so did you forget to remove it?

    And why createApi is global function, this is not a unique name for global function in WordPress, there are some other functions in gateway-revolut.php file that are missing your plugin prefix in name. e.g. “load_admin_scripts”, “load_scripts”, “validate_checkout_field”, “get_customer_base_info”, “load_rest_api”

    all these global functions should have plugin prefixes to avoid any conflict with WP core or 3rd party plugins and themes.

    Please review the code and fix all these issues if possible. People install this plugin with trust but we should have good code quality in the plugin whiling we are trusting a brand.

    Thanks

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author revolutbusiness

    (@revolutbusiness)

    Hello @vijayhardaha

    Thanks for contacting our team and for you feedbacks!

    We will review and solve the above cases as soon as possible.

    Plugin Author revolutbusiness

    (@revolutbusiness)

    Hello @vijayhardaha

    We refactored the cases which you mentioned above and launched it as a new version(2.3.2). Now you can update and test the plugin.

    Again thank you for your feedback!

    Feel free to ask if you have any question or if you need any future assistance.

    Best regards!

    Thread Starter Vijay Hardaha

    (@vijayhardaha)

    “set_webhook” value should be changed as well in revolut-settings.js based on last changes done on plugin. It’s not complete in last update

    I also noticed that “wc_revolut” is being localized twice in frontend, I checked why this is happening and I think you init enqueue javascript in abstract class constructor and this abstract class in extract in 2 methods so it’s running twice.

    I don’t think all the functions and hooks called in the abstract class constructor should be called and hooked twice. I think this coding can also be improved.

    Thanks
    Vijay Hardaha

    Plugin Author revolutbusiness

    (@revolutbusiness)

    Hi @vijayhardaha

    “set_webhook” value is updated now. About the abstract class yes currently the payment methods extends from the same class because of the current design of the plugin, but we also currently working on the new design that the hooks will be moved to a separate controller, in order to avoid double hooks.

    Best regards!

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Missing Dependencies’ is closed to new replies.