Mishandling exceptions in PHP 7

I’d also like an answer to this. I don’t know why my original post was marked as Resolved. Seems like it’s an easy fix, and customers shouldn’t need to edit the plugin to make it work.

Also, the second part of my question. Why is ai1ec registered to handle all exceptions from the entire wordpress site? Shouldn’t the plugin just handle it’s own exceptions? It would make troubleshooting easier if exceptions were isolated.

It would have been marked resolved because the fix was applied in a subsequent release.

Can you both @timwakeling-1 and @nluis3294 confirm what version of the calendar you are using?

For faster assistance, please log into your Timely account and open a ticket by clicking on the Get Help link, or click here: https://dashboard.time.ly/account/get-help.

[ Moderator note: Signature redacted. ]

• This reply was modified 7 years, 11 months ago by Jan Dembowski.

I tried it on 2.5.17. then, I updated to 2.5.18 and the problem is still there.

I downloaded 2.5.19 to look at that line of code, and that line of code still seems to look the same, unless you fixed it somewhere else?

I tested this by trying to create an object that doesn’t exist:

$config = new config\ThisDoesNotExist();

Even though the error was in a totally seperate plugin, I get the error in the ai1ec error handler:

Fatal error: Uncaught TypeError: Argument 1 passed to Ai1ec_Exception_Handler::handle_exception() must be an instance of Exception, instance of Error given in C:\blah\blah\htdocs\myWebsite.com\wp-content\plugins\all-in-one-event-calendar\lib\exception\handler.php:191 Stack trace: #0 [internal function]: Ai1ec_Exception_Handler->handle_exception(Object(Error)) #1 {main} thrown in C:\blah\blah\htdocs\myWebsite.com\wp-content\plugins\all-in-one-event-calendar\lib\exception\handler.php on line 191

I’m looking at the change logs for 2.5.18, and I can’t find any mention of this. I can’t find any change logs for 2.5.19.

Update: I just installed 2.5.19 directly from the website, and I still get the exact same problem. Also, that line still looks exactly the same. Did you fix it by changing somewhere else in the code?

Hi @nluis3294

Just to correct and clarify, the fix is basically that the wordpress plugin is moving to be phased out and replaced by our Saas hosted calendar in order to minimize potential conflicts, and maximize user compatibility across multiple platforms and devices… for this, there is no ETA, but the development team is actively working on the release to be as soon as possible.

[ Moderator note: Signature redacted. ]

• This reply was modified 7 years, 11 months ago by Jan Dembowski.

Ok, thanks for clarifying.

Do you have any documentation about what this SAAS calendar will look like, and how it’ll work? Does this mean the data for our calendars will be hosted with you?

Hi @nluis3294

I don’t have documentation yet. The functionality will be similar to, and better than current functionality, as there will be more features than our current versions. Currently we have the WordPress Core, the Hublite and Hub (hosted), but the Saas hosted will eventually phase them all out. Sorry, there is no ETA yet.

[ Moderator note: Signature redacted. ]

• This reply was modified 7 years, 11 months ago by Jan Dembowski.

Thank you Sunny. I appreciate that.

However, surely you can put this fix in place? It’s only three lines of code and you’ve just released another update with more complicated fixes than that… ??

I’m using v2.5.18 as well – though I’ll update to 2.5.19 now and manually apply the code change again to keep things working.

Tim

Hello @timwakeling-1,

I appreciate your suggestion. I am not authorized to place any code changes. We have a development team and there are programmers that have a schedule and a backlog of tickets, of which bug fixes are priority, followed by proprietary development of code. There is a process and protocol for work orders in place that must be followed. Hope you understand.

For faster assistance, please log into your Timely account and open a ticket by clicking on the Get Help link, or click here: https://dashboard.time.ly/account/get-help.

Let me know if you require further assistance.

[ Moderator note: Signature redacted. ]

• This reply was modified 7 years, 11 months ago by Jan Dembowski.

I do indeed understand that. Though this is a pretty serious bug for anyone using PHP 7 which is rapidly entering mainstream, as your plugin grabs and mishandles exceptions from EVERY other part of the site. If it was my team, I’d be adding that to a fairly high level on the priority list. But then I don’t know what your other bugs are so maybe they are indeed even worse! I’ll shut up now and leave it to you. ??

Tim

Good point @timwakeling-1,

The severity level is low, only because of the available workaround mentioned above, and found here:

https://cjhaas.com/blog/2017/02/24/one-event-calendar-time-ly-exceptionerror-problem/

[ Moderator note: Signature redacted. ]

• This reply was modified 7 years, 11 months ago by Jan Dembowski.