Minor issue – Stats default timerange UTC-based

OK, great! I’ll add that function call to the start of all the relevant shortcode functions in the next release. Thanks for testing that.

Now regarding our back-and-forth:

My “idea” is not a “hypothesis.” ?? I’m explaining to you how it actually works. There is no ajax call for this javascript function. The only action it is performing is window.location = $thenewurltoload,dude

And in that new url is a query string, with parameters named however I see fit, and PHP itself (not WordPress, not a function I wrote, but PHP itself) will convert that query string into an associative array stored in the $_GET superglobal.

“In either case though…it doesn’t explain how ‘fsb’ and ‘fse’ values would get initialised on an initial call to a shortcode ahead of a javascript call to that shortcode function.”

Yes, it does. Because what’s in the URL precedes everything that is ever written in any WordPress plugin.

Ok…you are going to kill me now…

window.location is called via javascript. I have no problem with the logic flow for the javascript call. Let’s park javascript which is only triggered when the person clicks on the stats range start or end states to trigger the popup datepicker and subsequent javascript call to reset the $_GET[‘fsb’] and $_GET[‘fse’] via the url.

If I open my browser and type in the url for the web page that I have created that has your embedded stats shortcode the shortcode is called without $_GET[‘fsb’] and $_GET[‘fse’] being initialised.

No javascript involved.

Yes. And in that case, SEE LINES 10-11 of inc.stataway-range.php

??

isset($_GET[‘fsb’]) means:

Does the array key ‘fsb’ exist in the $_GET variable?

If you go straight to the page without fsb and fse in the URL, then isset($_GET['fsb']) will return false, and we will go on to define $begin and $end using lines 10-11.

You are absolutely right…your code is well written and that’s where I would have thought my errorlog statement would have triggered on the page refresh…but it actually triggered lines 5 & 6. Go figure.

I know it may not seem like it but we are actually on the same page…lines 10-11 should be doing the job. Give me 10 minutes and I’ll re-test to confirm my original test results.

And…thanks again for your patience. 10 minutes and we’ll call this a wrap ??

I’m not in a hurry. It’s all good.

Tell me what your error log thing is so I can try it myself.

And by the way, I just finished going through the plugin and making sure all times were current. For a few of them, I just used current_time(‘timestamp’), because there was only one date() call in the whole method. But in others, I added fileaway_utility::timezone(); to the top of the method, because it’s better than calling current_time() a bunch of times throughout the method, and IMO always better to set the default timezone for a method that is dealing principally with time.

Ok retesting complete…the jury has deliberated…and the decision is…I owe you a beer next time you’re in the land down under :-O Lines 10-11 are triggering. I swear to god that yesterday it was triggering on lines 5-6 and lines 10-11 were being bypassed. I wouldn’t have tested your patience otherwise.

So…all is good.

You asked about debugging…I was just putting errorlog statements in. Example:

if(isset($_GET[‘fsb’]) && isset($_GET[‘fse’]))
{
$begin = $_GET[‘fsb’].’ 00:00:00′;
$end = $_GET[‘fse’].’ 23:59:59′;
error_log(“ATimezone ” . $end);
error_log(“ATimezone2 ” . date(‘Y-m-d H:i:s’));
}
else
{
$begin = date(‘Y-m-d H:i:s’, strtotime(date(‘Y-m-d 00:00:00′).’ -1 week’));
$end = $now;
error_log(“BTimezone ” . $end);
error_log(“BTimezone2 ” . date(‘Y-m-d H:i:s’));
}

Yay! I’ll take a beer. You can mail me a Crown Lager.

It was fun, man.

Ah, nice. Thanks for sharing that. I’ve never used error_log() before. I always just if(current_user_can(‘administrator’)) echo $whatever; but error_log() is nice. Appreciated.

Cheers mate…you get saint status on the universal patience scale…probably a good characteristic to have in the land of the gun ??

Oh I have no patience for gun nuts.