Made Updates To Your Plugin

  • ResolvedPlugin Contributor Asitha

    (@asitha)


    7 years, 6 months ago

    Hey bud,

    Not really sure how to use SVN so I don’t know if it’s possible to add a pull request here. Anyway, I’ve made some updates to your code so that it’s a bit more user friendly to read and use. Also added some documentation on how to update the variables.

    https://github.com/asithade/lh-hsts

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author shawfactor

    (@shawfactor)

    many thanks, your code ius definitely more readable.

    It sis now incorporated to the latest version and you are a co-contributor

    It looks like this code change introduced a bug. In the previous version of the plugin, you’d be redirected by default to HTTPS if you were on the HTTP version of the correct domain (before ever visiting the site, and therefore before getting the Strict-Transport header for the first time). That is no longer so because $this->redirect is set in the code block that only gets executed if you are on HTTPS already.

    I fixed this locally by adding a single line. See https://gist.github.com/Trott/2c0f019542f157f511e2ee18fc8af01f. Not sure if that’s the best fix, but it certainly worked for me.

    • This reply was modified 7 years, 6 months ago by richtrottucsf.
    Plugin Author shawfactor

    (@shawfactor)

    Much appreciated and great pick up, I’ve incorporated the bug fix into the latest version.

    Thanks again

    Pete

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Made Updates To Your Plugin’ is closed to new replies.

Tags