Long URL with many query parameters slowing loading

Hi. What’s the URL of your site with PWA active?

https://www.sensorsone.com/length-area-volume-isotropic-thermal-expansion-calculator/?ab=4&v0=56&u0=degrees+Celsius+%28%C2%B0C%29&f0=C&v1=60&u1=degrees+Celsius+%28%C2%B0C%29&f1=C&v2=0.0005&u2=per+degree+Celsius+%28%2F%C2%B0C%29&f2=CdT&v3=100&u3=centimetres+%28cm%29&f3=cm&u4=centimetres+%28cm%29&f4=cm&v5=100&u5=sq+centimetres+%28cm%C2%B2%29&f5=sqcm&v6=100.4&u6=sq+centimetres+%28cm%C2%B2%29&f6=sqcm&v7=100&u7=cu+centimetres+%28cc%2C+cm%C2%B3%29&f7=cucm&v8=100.6&u8=cu+centimetres+%28cc%2C+cm%C2%B3%29&f8=cucm

Thanks. I see you’re using v0.6. Can you upgrade to v0.7 and see if this fixes the issue?

I tried this on another site yesterday and it didn’t seem ot make any difference, bit I’ve updated the one above and tested it, but there appears to be no difference. I’ve also tried the same query string on arbitrary pages and it loads very quickly with the plugin deactivated. It seems to be the number of parameters rather than the length of the string which is causing the issue, just removing one or two parameters from anywhere seems to drastically speeds up the loading

Still if you can update to the latest version of the plugin that will help when I surface to the Workbox team. I’ve already filed an issue regarding this: https://github.com/GoogleChrome/workbox/issues/3077

I was able to reproduce the issue on my own site. So you don’t have to upgrade for them to debug.

great thanks Weston, I’ve tried a simpler query string with the same number of parameters, and there does seem to be a threshold around the 26 mark, but maybe the url decoding is factoring into it as well, because I did notice it was a little faster.

Thanks to Jeff Posnick at the Workbox team for identifying the problem. The cause is a couple expensive regular expressions:

			// Exclude Customizer preview.
			$denylist_patterns[] = '\?(.+&)*wp_customize=';
			$denylist_patterns[] = '\?(.+&)*customize_changeset_uuid=';

As a quick fix, I suggest deleting those lines from this plugin file: wp-includes/components/class-wp-service-worker-navigation-routing-component.php.

In the meantime, I’m going to look at optimizing the regular expressions.

Thanks Jeff Posnick for spotting the problem area, and thanks Weston for taking the trouble to identify the regex to remove as a temporary fix, works a treat now ??

I’ve opened a pull request to fix this in the plugin: https://github.com/GoogleChromeLabs/pwa-wp/pull/780

I’m planning to release this as part of a 0.7.1 release next week.