• I updated the Make theme this afternoon. With the update, the logo that has been uploaded and specified no longer loads as part of the header section. I’m confused.

    I have a child theme in place and am using a header-layout.php replacement file in order to customize display the text portion of the logo as text… which is displaying… but I no longer see the logo (to the left). I have not changed anything with respect to the function that is called to display the logo, and I have tried disabling the header file in the child theme to see if it fixes the problem, but it does not. I have also cleared the logo files and attempted to re-add them. Still nothing.

    Any help would be appreciated.

    Thanks.

    whiterenovations.ca

Viewing 15 replies - 1 through 15 (of 18 total)
  • Hi @brentoage

    Sorry you’ve hit this problem. We’ve seen a couple of other reports of this, but are so far unable to reproduce the issue.

    When you say you’ve cleared the logo files, do you mean just removing them in the Customizer? Have you tried re-uploading them from your computer?

    Thread Starter brentoage

    (@brentoage)

    When you say you’ve cleared the logo files, do you mean just removing them in the Customizer? Have you tried re-uploading them from your computer?

    I cleared them from the Customizer, and deleted the corresponding files from the Media Library. I then returned to the Customizer, re-uploaded the same files, but still… no logo.

    Hmm. A couple more questions:

    * If you temporarily disable your plugins, and then try uploading the logo file, does that make a difference?
    * Is your site part of a multisite network? Are there any other aspects of your WordPress configuration that are unusual?

    Thanks for your patience while we get this figured out.

    Thread Starter brentoage

    (@brentoage)

    All of my plugins are currently disabled, and no, the site is not part of a multisite network.

    Nothing unusual in terms of configuration that I can think of. Standard install, not much going on.

    Ok, thanks for the info. We are still trying to figure out why some people are having a problem and others are not.

    If you are comfortable modifying the theme code, here is a temporary workaround you can try:

    Edit the file inc/customizer/helpers-logo.php, and remove these lines (88-92)


    // Function introduced in 4.0
    if ( function_exists( 'attachment_url_to_postid' ) ) {
    $attachment_id = attachment_url_to_postid( $url );
    return ( $attachment_id ) ? $attachment_id : 0;
    }

    After making this change, you might need to upload the logo image again. Please let us know if this works for you.

    Thread Starter brentoage

    (@brentoage)

    Edit the file inc/customizer/helpers-logo.php, and remove these lines (88-92)

    // Function introduced in 4.0
    if ( function_exists( 'attachment_url_to_postid' ) ) {
    $attachment_id = attachment_url_to_postid( $url );
    return ( $attachment_id ) ? $attachment_id : 0;
    }

    After making this change, you might need to upload the logo image again. Please let us know if this works for you.

    Alright, so… I tried this.

    First, I commented out the lines specified in helpers-logo.php. I then cleared everything from the Customizer and re-up’d the images…

    …and still nothing.

    Ok, here’s a shot in the dark: logo image info gets cached using its filename as part of the key. With that code still commented out, try uploading the logo with a different filename.

    Thread Starter brentoage

    (@brentoage)

    Ok, here’s a shot in the dark: logo image info gets cached using its filename as part of the key. With that code still commented out, try uploading the logo with a different filename.

    Boom. Fixed.

    Thank you.

    Whew! Glad that’s resolved!

    Ok, now here’s the kicker: if you uncomment those code lines, and then upload with a different filename, what happens?

    Thread Starter brentoage

    (@brentoage)

    Ok, now here’s the kicker: if you uncomment those code lines, and then upload with a different filename, what happens?

    The logo disappears when I uncomment the code and upload the same images using a different file name for each. Bummer.

    Ok, well at least that isolates the problem. Not sure why it works for me, but not for you. Thanks for helping us track down the issue!

    We’ll get a fix submitted ASAP.

    Thread Starter brentoage

    (@brentoage)

    Always happy to assist. I’ll keep an eye out for a fix.

    Have a good day.

    @brentoage if you would like to try a patch we are working on, here’s the revised version of the helpers-logo.php file.

    Thread Starter brentoage

    (@brentoage)

    if you would like to try a patch we are working on, here’s the revised version of the helpers-logo.php file.

    Hey Corey. I applied the patch and the logo seems to be working. Thanks!

    Awesome! Thanks for trying it out.

Viewing 15 replies - 1 through 15 (of 18 total)
  • The topic ‘Logo has disappeared since update’ is closed to new replies.