Location filter not working with accents

  • Resolved stefan.kruger

    (@stefankruger)


    11 months, 1 week ago

    Hello,

    We’re using your plugin on a client website and we noticed a small bug in sanitization due to accents in location names.

    The plugin version is 3.4.24

    Example

    Location name : Théatre Cornillon

    When filtering on this location on the main calendar page returns no events.

    The problems seems to be the map_deep sanitize_text_field which is run on the $_GET array.

    File : wp-content/plugins/my-calendar/my-calendar-events.php
    Method : my_calendar_get_events
    Line : 111

    The result for this location is the name is truncated.
    When filtering the name passed through GET parameter is Th%C3%A9%C3%A2tre+Cornillon

    (MAIN_URL + /my-calendar/?ltype=name&loc=Th%25C3%25A9%25C3%25A2tre%2BCornillon)

    After sanitization this name is transformed to Thtre+Cornillon which is not recognized.

    For now i have edited the code to make it work by disabling sanitization, i know it’s not really good regarding security but it would be great if you could provide an update to the actual plugin to make it work.

    Thank you.

    Stefan.

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Joe Dolson

    (@joedolson)

    I am aware of this issue; it’s already fixed for the next release, which I expect to release in about a week.

    Thread Starter stefan.kruger

    (@stefankruger)

    Hi Joe,

    Thank you for your anwser, looking forward to the update.

    Regards,

    Stefan.

    Thread Starter stefan.kruger

    (@stefankruger)

    Hi @joedolson ,

    I’ve checked the development changelog and i can’t find something about the posted problem.
    Is this bug fixed yet ?

    Regards,

    Stefan.

    Plugin Author Joe Dolson

    (@joedolson)

    Well, it certainly should be – but if you’re still experiencing the problem on the latest release, let me know.

    Thread Starter stefan.kruger

    (@stefankruger)

    Hi Joe,

    Thank you for the fast answer, i’ll check this on a staging copy and will let you know and close this topic if it’s all good.

    Have a nice day ??

    Stefan.

    Thread Starter stefan.kruger

    (@stefankruger)

    Hi @joedolson ,

    I’ve check with another location having events and a name containing accents and it’s all working good.
    Thank you for the fix.

    Regards,

    Stefan

    Plugin Author Joe Dolson

    (@joedolson)

    Thanks for following up!

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Location filter not working with accents’ is closed to new replies.