Viewing 6 replies - 1 through 6 (of 6 total)
  • davide

    (@davidemetupit)

    Yes, me too, link has href attribute empty (<a href="" title="...)

    If I revert widget.php at lines 396-397:

    $link  = $instance['link_image_field'] ? $instance['link_image_field'] : get_permalink();
    $link  = genesis_get_custom_field( 'gsfc_link_image_field' ) ? genesis_get_custom_field( 'gsfc_link_image_field' ) : $instance['link_image_field'];

    and restore

    $link  = $instance['link_image_field'] && genesis_get_custom_field( $instance['link_image_field'] ) ? genesis_get_custom_field( $instance['link_image_field'] ) : get_permalink();

    Link is ok

    I am seeing this as well and can verify it was working correctly in earlier versions.

    +1 to the above posters…

    +1 to above. The fix above worked great though. Hopefully will be fixed in the next release.

    I was having the same problem. Thanks for the fix. I hope this will be fixed in the next release.

    Plugin Author Travis Smith

    (@wpsmith)

    This actually isn’t a good fix. Essentially the fix is bogus because:

    Let’s say Widget Setting link_image_field is blank, which for most people it is. Then…
    $link = $instance['link_image_field'] && genesis_get_custom_field( $instance['link_image_field'] ) ? genesis_get_custom_field( $instance['link_image_field'] ) : get_permalink();
    …results in this:
    $link = '' && genesis_get_custom_field( '' ) ? genesis_get_custom_field( '' ) : get_permalink();`
    …which when evaluated results in this:
    $link = '' && '' ? '' : 'https://domain.com/permalink';

    So the conditional will always be false. Thus, not a good fix. This was fixed in 1.1.7. Please update.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘"Link to image" not working’ is closed to new replies.