• Resolved Jihad Sinnaour

    (@jihad-sinnaour)


    In the latest versions of plugin, Line breaks (“\n”) are converted to Spaces, after saving settings,
    e.g “Review textarea
    That breaks my website!
    Any explanation for this change?

    Plugin version : 4.2.6.9.2
    Wp version : 6.6.1 (Fresh install, basic theme, no other plugins)

    Thanks!

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Support brianvu-tp

    (@briantp)

    Hi Jihad Sinnaour,

    Thank you for bringing this to our attention.

    Could you please specify where you are encountering the issue with line breaks being converted to spaces? For example, is it happening in the content of lessons, content of courses, titles of quizzes, answers, or another area? This information will help us investigate the cause and find a solution for you.

    Best regards,
    Brianvu-tp

    Thread Starter Jihad Sinnaour

    (@jihad-sinnaour)

    Hello,

    Im encountering the issue in the “Course” admin area:
    Example: Textarea (metabox) “_lp_featured_review

    Reproduce action:
    – Set a list of strings using line break in the “_lp_featured_review”, e.g list of emails
    – Save CPT “lp_course

    Excpected behavior:
    – After updating the CPT “lp_course”, Line breaks (“\n”) in “_lp_featured_review” should not be converted to spaces.

    Original issue:
    – I Built an add-on to add textarea “_foo_lp_email_list”, using Filter “lp_course_data_settings_tabs” & by extending LP_Meta_Box_Textarea_Field class, Now the behavior is changed.

    Possible causes:
    – WordPress update that have impacts on your plugin saving CPT action hook
    – Your plugin’s update..

    Thanks

    Plugin Support brianvu-tp

    (@briantp)

    Hi Jihad Sinnaour,

    Thank you for providing detailed information about the issue.

    The change in behavior is due to a recent update addressing security concerns, which inadvertently affected the handling of line breaks in textareas like “_lp_featured_review.”

    We understand the impact this has on your functionality and will investigate the issue to see if we can find a solution. We will notify you once we have an update or a fix.

    Thank you for your patience and understanding.

    Best regards,
    Brianvu-tp

    Thread Starter Jihad Sinnaour

    (@jihad-sinnaour)

    _lp_featured_review was juste example to explain the issue !!

    you shouldnt remove line breaks on custom textarea ! for security use sanitize_textarea_field…

    well, thanks anyway

    Plugin Author ThimPress

    (@thimpress)

    Hi jihad-sinnaour,

    _lp_featured_review was juste example to explain the issue !!

    – Oh we see that, we’ll fix soon, thank for your feedback.


    you shouldnt remove line breaks on custom textarea ! for security use sanitize_textarea_field…

    – We don’t have intention to remove line breaks, it is bug when we fix security, we don’t know that, now we see and will fix the next version.

    Thank so much.
    Best Regard!

    Plugin Author ThimPress

    (@thimpress)

    Hi jihad-sinnaour,

    We upload the beta version to fix issues, please check then feedback to us.

    Thank so much.
    Best Regard!

    Thread Starter Jihad Sinnaour

    (@jihad-sinnaour)

    Great to hear! Thanks

    Plugin Author ThimPress

    (@thimpress)

    Hi jihad-sinnaour,

    Thank you for that, it’s great news for us. We’re continuously working hard to enhance LearnPress, making it better than yesterday. We’ve made changes to the core system code to improve extensibility, maintenance, and stability. Along the way, we anticipate encountering various issues and problems. Please reach out to us, we’ll check and address them. If you have any questions or solutions, discussing them with us would be very helpful.

    LearnPress is set to undergo significant changes soon. As a developer, your input is valuable to us, so you can participate in beta testing or provide feedback for the code. We have created a core that is free for developers to easily build features around it, to better serve the community. We will soon disable template file overriding, developers should use hooks for customization. We will provide hooks with all the necessary data for customization. Your feedback is crucial to us.

    Thank you so much.
    Best Regard!

Viewing 8 replies - 1 through 8 (of 8 total)
  • You must be logged in to reply to this topic.