Limit prices in documents to 2 decimals

Hey @spoonofmilk,

I’m wondering if increasing the priority of the function would help in any way, so trying with 999 where 10 appears:

add_filter( 'wpo_wcpdf_order_item_data', function( $data, $order, $document_type ) {
	if( isset( $data['weight'] ) ) {
		$data['weight'] = number_format( $data['weight'], 2 );
	}
	return $data;
}, 999, 3 );

Hi Darren

Thanks for the reply! Mine’s not for weight in this case, but the different order values (line items, subtotal and total) where I need to override the store setting of 4 decimals and replace with 2. I think it may just be a case of not knowing what the label names are though (ie, $data[‘price’] etc). That’s kind of what I was hoping for help with!

@spoonofmilk,

Understood, let’s try this below instead. ??

add_action( 'wpo_wcpdf_before_document', function( $document_type, $order ) {
	if( ! empty( $order ) && $document_type == 'invoice' ) {
		add_filter( 'wc_price', 'remove_price_decimals', 10, 3 );
	}
}, 10, 2 );
add_action( 'wpo_wcpdf_after_document', function( $document_type, $order ) {
	if( ! empty( $order ) && $document_type == 'invoice' ) {
		remove_filter( 'wc_price', 'remove_price_decimals', 10, 3 );
	}
}, 10, 2 );
function remove_price_decimals( $return, $price, $args ) {
	$arr = explode( ',', $return );
	return $arr[0];
}

THanks for the continued help! I have just added that to the theme functions file and generated a new invoice, but same issue?

https://pasteboard.co/K1fXqEA.png

Hey @spoonofmilk,

My apologies, a ‘comma’ needs to be replaced with a ‘point’. Try this:

add_action( 'wpo_wcpdf_before_document', function( $document_type, $order ) {
	if( ! empty( $order ) && $document_type == 'invoice' ) {
		add_filter( 'wc_price', 'remove_price_decimals', 10, 3 );
	}
}, 10, 2 );
add_action( 'wpo_wcpdf_after_document', function( $document_type, $order ) {
	if( ! empty( $order ) && $document_type == 'invoice' ) {
		remove_filter( 'wc_price', 'remove_price_decimals', 10, 3 );
	}
}, 10, 2 );
function remove_price_decimals( $return, $price, $args ) {
	$arr = explode( '.', $return );
	return $arr[0];
}

@spoonofmilk,

After some more testing, I found that this code snippet will do the trick for you:

add_filter( 'wc_get_price_decimals', 'change_prices_decimals', 999, 1 );
function change_prices_decimals( $decimals ){
	$decimals = 2;
	return $decimals;
}

I tested it by setting my environment to 3 decimal places, since I was already at 2:

Thanks so much for the help, Darren, seems to have done the trick nicely! Very much appreciated!

@spoonofmilk,

I have not-so-great news. It turns out this last solution I posted is not recommended either because this could cause issues in the checkout or when multiple emails are sent in a row because after the PDF is then created, it shows with 2 decimals EVERYWHERE.

I apologize for this, it’s better not to use that. I’ll keep looking for a better solution & will post here. ??

That actually works for my purposes anyway, at least in this very specific case. However if you hit on a better long term solution that would be great to know!

@spoonofmilk,

I believe this is a safer/better solution:

add_action( 'wpo_wcpdf_before_html', function( $document_type, $document ) {
	add_filter( 'wc_get_price_decimals', 'wpo_change_price_decimals', 10, 1 );
}, 10, 2 );
add_action( 'wpo_wcpdf_after_html', function( $document_type, $document ) {
	remove_filter( 'wc_get_price_decimals', 'wpo_change_price_decimals', 10, 1 );
}, 10, 2 );
function wpo_change_price_decimals( $decimals ) {
	return 2;
}

Thanks again, Darren, that’s super!