• Resolved chucklebum0205

    (@chucklebum0205)


    Hi There,

    I’ve recently updated to v 1.11 and this version seems to prevent some scripts from loading within the admin that breaks functionality of other plugins – eg yoast seo, the media browser no longer loads in an iframe etc. Rolling back to v 1.10.2 and the problem goes away. Can you take a look?

    Here’s the error message when editing a product:

    Uncaught DOMException: Failed to execute 'insertBefore' on 'Node': The new child element contains the parent.
        at HTMLDivElement.<anonymous> (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:3:23139)
        at Ga (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:3:20945)
        at a.fn.init.after (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:3:23076)
        at a.fn.init.n.fn.<computed> [as insertAfter] (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:3:24358)
        at HTMLDocument.<anonymous> (https://staging.thecraft-studio.com/wp-admin/post.php?post=64193&action=edit:8288:54)
        at i (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:2:27362)
        at Object.fireWith [as resolveWith] (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:2:28121)
        at Function.ready (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:2:29914)
        at HTMLDocument.J (https://staging.thecraft-studio.com/wp-admin/load-scripts.php?c=0&load%5Bchunk_0%5D=jquery-core,jquery-migrate,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-sortable,utils&ver=5.4:2:30276)

    thanks

    Brian.

Viewing 13 replies - 16 through 28 (of 28 total)
  • dmac

    (@darrenmcentee)

    Thanks, yes I’ve tried this on one client site and it seems to work, thanks.
    We’ve another 22 sites to fix, all with the same issues, so I’d prefer an official module fix ??
    Thanks,
    Darren.

    Hey @darrenmcentee!

    I can certainly understand that ?? I’ll catch up with our developers now that we can reproduce this locally to see if there is anything we can do to avoid the error when Disable Admin Notices is active. Are you using this disable admin notices on all 22 sites that you manage?

    I’ll circle back around here as soon as I hear more, thanks so much for your patience!

    Cheers,

    Simon.

    Hi @darrenmcentee,

    Our developers have had an initial look at this one. After some time investigating it looks like the code of Disable Admin Notices is unable to work alongside the delayed notices that the plugin is generating. As we only attempt to print the notice when a product has been updated, for some reason the code to make this notice visible at the right time, is not working with how the Disable Admin Notices plugin is hiding them.

    I can’t say if we’ll be able to resolve the conflict at this point, as it’s not clear to me if there is some oddity with the way the notices are hidden, or if it would be possible to display these delayed notices differently. Our developers would require more time to investigate more thoroughly, and that will require prioritization from the product team.

    If possible we would recommend disabling the hide admin function or plugin, or alternatively using the snippet to dismiss the notice in order to keep it active, or even temporarily disabling the disable admin notices plugin so that the notice can be dismissed manually first.

    The final option is to wait until the latest plugin release which will bring back the visibility and syncing functions and so the notice will no longer be printed.

    I’m sorry there’s no complete solution at this time, though I hope one of these workarounds would be suitable for you. If you have any other questions, please could you let me know?

    Cheers,

    Simon.

    Facing same issue as well.

    Hi @alibasheer,

    Thanks for letting us know. I’m afraid our product team will need to assess this in more detail, as the issue seems to be caused by the way the Disable Admin Notices plugin is editing the admin notices, causing an uncaught JavaScript exception. To avoid this, there will need to be specific compatibility added when this plugin is active.

    As this notice is only temporary until the new version is released, there is a workaround which I would suggest using for the time being. It is possible to use a custom snippet to dismiss the notice on next login, so that it no longer outputs the admin notice and avoids the error altogether!

    If you’d like to give this a go, you can find the snippet here: https://gist.github.com/da4454d97e3012a03f6d64ad9ec9949b

    Please note that the snippet will run on each page load, so I would advise to only keep the snippet active for the initial login of your admins. The issue should not show itself once the notice has been dismissed, and therefore the snippet isn’t required to be active after that.

    You can add this snippet to your theme’s function.php file, or use a plugin such as Code Snippets which is a favorite of mine, as this allows easy activation/deactivation and safe mode should anything go wrong!

    Will you be giving this snippet a go or waiting for the next major release of our plugin?

    Cheers!

    Simon.

    I noticed that it is a conflict with Disable Admin Notices. For the time being, I will deactivate the “Disable Admin Notices” plugin till your next update.

    Thank you, dear. Awesome support.

    Hey @alibasheer,

    That works too! If you’d to give the workaround snippet above a try though, that should allow you to keep the Disable Admin Notices plugin active at the same time.

    Of course, leaving it deactivated is certainly the easiest option! ?? If you run into any other issues, please do let me know.

    Cheers!

    Simon.

    dmac

    (@darrenmcentee)

    Hey,
    Any update on an official fix release?
    Thanks.

    Hey @darrenmcentee,

    Not at this time I’m afraid! Our developers are working hard at getting the latest release available that uses Facebook’s new API and brings better performance for syncing and brings back the visibility options.

    By doing so, the notice will no longer be required, and merchants will have the features we had added in previous versions to help them better manage their sync with Facebook.

    While I understand this isn’t ideal for the current plugin when using Disable Admin Notices, the decision was made to focus on the new version rather than investigate compatibility with a plugin that is adjusting the admin notice in a way that causes a conflict.

    Hopefully we’ll have the new version ready for you soon so you can give it a go!

    Cheers,

    Simon.

    dmac

    (@darrenmcentee)

    Hi, thanks.
    Does v1.11.3 patch this specific bug?
    Cheers,
    Darren.

    Hi @darrenmcentee,

    I’m afraid not, 1.11.3 is a minor release which contains items that were added to the new major release the developers are still working on, yet we wanted to get out even earlier as they were causing some merchants problems with products disappearing. Most notably the issue with Facebook being able to retrieve a partial feed file.

    The full list of fixes and tweaks in the latest version is:

    Tweak – Write product feed to a temporary file and rename it when done, to prevent Facebook from downloading an incomplete feed file
    Tweak – Hide Facebook options for virtual products and virtual variations
    Tweak – Do not allow merchant to bulk enable sync for virtual products
    Tweak – On upgrade, automatically disable sync for virtual products and virtual variations
    Tweak – When using checkboxes for tags, make sure the modal is displayed when trying to enable sync for a product with an excluded tag
    Fix – Prevent tracking of a duplicated purchase event in some circumstances such as when the customer reloads the “Thank You” page after completing an order
    Fix – Fix a JavaScript issue that was causing a notice to be displayed when bulk editing product variations

    Once the new major version is available, that should remove the visibility notice, and hopefully avoid the current issue you’re seeing.

    Cheers,

    Simon.

    dmac

    (@darrenmcentee)

    Ok, thanks for the update.

    dmac

    (@darrenmcentee)

    Hi,
    Does v2.0.0 patch this specific bug?
    Cheers,
    Darren.

Viewing 13 replies - 16 through 28 (of 28 total)
  • The topic ‘Latest version seems to break woo functionality’ is closed to new replies.