last_id in wp_options still growing?

Hi Darek,

thanks for your post, and sorry for the trouble.

The “last_id” value there is not the value that tells TablePress how many tables there are, but what the last ID that has been used for new or imported tables was. This is necessary to make sure that no ID is used twice. That could lead to a wrong table in the wrong post/page otherwise, if someone forgets to update/remove a Shortcode from a page/post after deleting a table.

Regards,
Tobias

Tobias,

I am not sure what You mean with the “last_id” and where it is used. However this code here is wrong, there should be foreach instead of for ??

Thanks,
Darek

Hi Darek,

when a new table is added or imported, it needs to get a new ID, and that “last_id” value tells TablePress which ID is “safe” and has not been used on the site before. Making sure that a new table gets a previously unused ID is important, because there might be Shortcodes to no longer existing tables in posts/pages, and without that check they might suddenly show a table again.

And yes, your for-loop is then wrong. But as I tried to say in that other thread, the rest of the code is also not ideal. You should directly use load_all() and load() from the TablePress_Table_Model class. You won’t have to care about handling JSON then and you won’t have to deal with manual string replacements.

Regards,
Tobias

Tobias, the same is when You have tables and You choose “update existing” in import menu. The existing ones should be overwritten but they don’t, new has been created.

Hi,

I can’t reproduce this, or I’m misunderstanding you. When I import a table and choose to replace an existing one, the “last_id” value remains unchanged for me.

Regards,
Tobias

Tobias, I have it on wordpress 4.0 site with the latest tablepress plugin (original). I am not sure if other versions has it too. I observed it first time yestarday.

Hi Darek,

what exactly did you observe? I’ll need detailed reproducible steps here.
From your “ou choose “update existing” in import menu. The existing ones should be overwritten but they don’t, new has been created.” I can only assume that somehow no table that shall be replaced was chosen.

Regards,
Tobias

I’ll need detailed reproducible steps here

Tobias,

1. backup all tables (You need 3 tables) to json zip file
2. remove all tables via tablepress panel
3. import all tables from backuped json zip file
NOTE: Now You should have 3 tables again
4. go to import but this time choose replace and choose 1st table
NOTE: All tables will be imported again so You should have 6 tables.
There will not be 1st table replacement.

If You import one table and choose replace, it works fine.

Regarding last_id: I replaced the for loop with foreach so the last_id problem is resolved.

Regards,
Darek

Hi Darek,

ah, thanks for the clarification, now I see what you mean!
The “Replace existing table” feature will only work when importing a single table, it will however not work if one imports multiple tables (in a ZIP file) at once. In that case, the tables will be added with new IDs instead.

Good to hear that switching to a foreach-loop helped! ??

Regards,
Tobias