Last update, settings page blank

@mariogatti84

Looks like a MultiSite specific bug introduced in the 5.4.0 release …

To fix it change the following lines in the wp-content/plugins/better-wp-security/core/admin-pages/init.php file:

if ( 'settings' === $page_id ) {
	$url = admin_url( 'admin.php?page=itsec' );
} else {
	$url = admin_url( 'admin.php?page=itsec-' . $this->get_page_id() );
}

into:

if ( 'settings' === $page_id ) {
	$url = network_admin_url( 'admin.php?page=itsec' );
} else {
	$url = network_admin_url( 'admin.php?page=itsec-' . $this->get_page_id() );
}

Untested, so try this at your own risk.

dwinden

Hi dwinden,

thanks for your answer, but unfortunately, the website is online, so I can’t take any sort of risk ??

Thanks

@mariogatti84

I’m sorry to hear that (If it helps, I’m 99% sure it will fix the issue).

You could install a test MultiSite WordPress env and test the fix in that env before applying it online.

That said, if iThemes had tested the new release on MultiSite this issue would never have happened. Seems like this release was not tested at all on MultiSite. So there may be a lot more MultiSite issues …

dwinden

Yep ..

I will try it, hope it works! Update to this fix in the next hours! ??
Stay tuned

Thanks

iThemes Settings gone blank at all my sites except one… this is super weird.

Mmh.. weird here too: I’ve tried with the dwinden’s suggestion and this is the final outcome:
replicating the online website in WordPress multisite, make an exact copy …. it works!
But in the online still remain the same.

What’s goin’ on? O.o

@mariogatti84

I am experiencing similar behavior.

The All and Advanced links are definately incorrect in MultiSite as they point to:

https://www.domain.com/wp-admin/admin.php?page=…

while they should be pointing to:

https://www.domain.com/wp-admin/network/admin.php?page=…

Oddly the https://www.domain.com/wp-admin/admin.php?page=… links work for All and Advanced !
Except the View Logs button. It consistently reports:

You do not have sufficient permissions to access this page.

Which is to be expected in MultiSite based on the url (https://www.domain.com/wp-admin/admin.php?page=itsec-logs).

I’m pretty sure your View Logs button also does not work in any MultiSite env.
Note as a workaround you can access the Logs page from the Security -> Logs menu option ! That link is correct for MultiSite.

I’m still convinced my fix will solve this multisite issue when it occurs.

To be continued …

dwinden

xD thanks again dwinden!

For links you solve it: introducing /network/ into URLs I can find the All and Advanced tab’s pages, but still blank both.

I have other installation with multiwebsite and this plugin .. I will try to update the plugin into these too, in dev mode. Maybe I will be lucky (or unlucky xD .. ) and the bug will come again .. so I can try your solution into init.php file.

Let me try!

To be continued again ..

Ok, we are lucky: find a dev multisite with the same problem!

The tabs now have the exact URLs but still blank page.

Let me know, we can make changes on plugin’s files now! Hurray!

@mariogatti84

Ok, great.

To fix the View Logs button link for MultiSite change the following line in the get_logs_page_url() function in the class-itsec-core.php file:

$url = admin_url( 'admin.php?page=itsec-logs' );

into:

$url = network_admin_url( 'admin.php?page=itsec-logs' );

To be continued …

dwinden

@mariogatti84

To fix the Manage Settings button link for MultiSite change the following line in the get_settings_page_url() function in the class-itsec-core.php file:

$url = admin_url( 'admin.php?page=itsec' );

into:

$url = network_admin_url( 'admin.php?page=itsec' );

To be continued …

dwinden

Ok, done it and working. Both functions are ok.
Pages still blank but links work.

What’s next? ??

Ok, maybe I solve it: it’s a simple and stupid CSS problem.

'.hidden, .js .closed .inside, .js .hide-if-js, .js .wp-core-ui .hide-if-js, .js.wp-core-ui .hide-if-js, .no-js .hide-if-no-js, .no-js .wp-core-ui .hide-if-no-js, .no-js.wp-core-ui .hide-if-no-js'

contained into /wp-admin/load-styles.php is set to display: none

If I change it into display block, I can see all the tabs and the popups with the changes.

You can see it here: https://s-media-cache-ak0.pinimg.com/originals/61/5e/c2/615ec24f35d807e1cec16e6e32accdab.png
with css display: block and all the popups deleted.

If only set to display block here:
https://it.pinterest.com/pin/22729173098596643/

Hurray!

Ok, guys, everything is ok with 5.4.1

Good job!

Hey All,

The Multisite link issue is now resolved in 5.4.2.

Thanks!

Gerroald