JavaScript source code

  • Resolved franga2000

    (@franga2000)


    4 years, 10 months ago

    Hi!

    I’ve been working on some modifications of this plugin to add support for custom taxonomies, which lead me to discover that parts of the JavaScript scripts you distribute in the source repository are only available in minified and obfuscated form (editor.blocks.min.js – specifically the last “line”).

    This not only makes contributions from other developers such as myself much more difficult, but also presents a clear violation of rule 4 of the www.remarpro.com plugin guidelines as well as the GPLv3 itself (section 1, paragraph 1).

    I am therefore requesting you release the full, unobfuscated source code of the aforementioned files, so we may inspect, modify and contribute changes to the code as the license permits us.

    P.S.: this is a great plugin and I merely wish to further improve it (which is something you would benefit from as well). Unfortunately, all licensing discussions end up sounding harsh, which was certainly not my intention. I am very grateful that you released it for free! That being said, I would appreciate it if you could release the code as soon as possible as I am running up against a deadline and what I axpected to be a simple modificastion has now turned into hours of reverse-engineering.

    • This topic was modified 4 years, 10 months ago by franga2000.
Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author WPXPO

    (@wpxpo)

    Hello @ franga2000,
    Yes, you are right. According to the rules we have to given unminified version of the source code. But the problem in React JS is it creates a much bigger file, that’s why many developers avoid giving the file inside the plugin. Because it made the plugin bulky. Suppose our built file is 421kb, on the other hand, the main source file is 4.3MB.

    Here is the link source download link-
    https://drive.google.com/file/d/1loHNFergVZZcUm8IAWvWVbHbOC8AXDZO/view?usp=sharing

    Note: Next update we will add unminified version of the source code.

    Thanks a lot

    Thread Starter franga2000

    (@franga2000)

    Hi!

    This looks like the unminified bundle to me. I’m assuming there’s a build step before it that converts the original source files into the bundle. In particular, it looks like you’re using JSX here, am I right? I suppose this might satisfy the WordPress requirements, but probably not the GPL ones. I guess it is technically what I asked for, but it seems I wasn’t thorough enough with my request.

    The reason for this post in the first place was because I want to contribute improvements to the plugin and even if I manage to make them on the provided code, I doubt you’d be able to merge in any changes if I sent you the diff on the bundle.

    So I’d like to to ask you if you would be willing to provide the original source code (i.e. the source files before any build step and including the build configurations), possibly on a site like GitHub, so I and other developers would be able to make modifications properly and allow you to easily integrate any that you liked into the plugin.

    You have yourself quite possibly the best Gutenberg post block plugin on this site, but it of course has some flaws and missing features. As it stands, your plugin is already under the GPL so anyone is allowed to modify and distribute it. But you are losing out on those modifications which would ultimately benefit you as well.
    I, for example, need support for custom post types with custom taxonomies. This is currently impossible with this plugin and so I intended to modify the plugin to make it possible and publish the modified source, which you could then pull into the plugin so everyone can benefit from it. Instead, without the actual source, I will either have to make the changes in the bundle and never update it again, or make my own plugin from scratch as I haven’t found any others that are even close to this good.

    Plugin Author WPXPO

    (@wpxpo)

    Hello @franga2000,
    We open our source code in bitbucket. Here is the link –
    https://bitbucket.org/wpstabon/ultimate-post/src/master/

    Now you can modify the source code whatever you want. Most probably you are a developer if you have any suggestions about our plugin let us know. We will try to improve our plugin as soon as possible.

    Thanks.

    Hi wpxpo,

    I noticed that on your file ‘editor.blocks.js’ you are still using webpack to mangle, bundle and obscure code and its against the plugin guidelines as stated in rule 4 of the www.remarpro.com plugin guidelines. It is making it impossible for anyone to modify the code in javascript. Please provide the full source code under the terms and guidelines of www.remarpro.com.

    Thanks

    Plugin Author WPXPO

    (@wpxpo)

    Hello @pietvvv,

    Yes, you are absolutely right, according to rule 4 of the www.remarpro.com plugin guidelines you have to give editable source code inside the plugins. Maybe you are a developer. But it developed using reactjs you know that and the source code is quite heavy. So we were given this source code git version control system. You can edit whatever you want. And we were given the source code link at the bottom of the plugin description.

    Contribute to Gutenberg Post Blocks on Bitbucket
    https://bitbucket.org/wpstabon/ultimate-post/src/master/

    We already discuss this with WordPress moderator. If you have any more query or suggestions let us know.

    Thank you so much.

    Hi wpxpo,

    Thank you – you guys are awesome! I can see the reactjs source directory on the link provided and it is what was missing. I appreciate the quick response. Keep up the good work!

    Thanks

    Plugin Author WPXPO

    (@wpxpo)

    Hi @pietvvv,

    I hope your issue is solved. If you are satisfied with our support then give us a five-star review in the WordPress directory. As a new plugin developer, it helps us a lot.

    Have a nice day.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘JavaScript source code’ is closed to new replies.