It breaks existing links

  • Please, correct it: don’t set links “above” existing links, especially breaking an existing anchor into parts: invest into oursocial network in the “Link to the page you need help with”. The link should be preserved as is rather than modified, and even if modified, the space after “our” should not be lost.

    The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Lucian Apostol

    (@thedark)

    Hello.

    Thank you for reporting this issue.

    The plugin should not alter the existing links, however, it seems that in this particular case it is not working as expected.

    Probably the cause is the use of sup and mark tags inside a tag, but I will try to find a way to prevent this problem.

    Thread Starter porton

    (@porton)

    <sup> is from “Affiliate links disclosure: <sup>ad</sup>”.
    <mark> is a part of the page’s text.

    Thread Starter porton

    (@porton)

    The HTML code is:

    <p>Please, <a title="Invest into Our Social Network" ><mark style="background-color:#ffb606" class="has-inline-color"><strong>invest into our social network</strong></mark></a>.</p>

    • This reply was modified 11 months, 1 week ago by porton.
    Thread Starter porton

    (@porton)

    Even worse, at https://docs.zoncircle.com/vote/ our link “investment” is fully overridden by an ad link and “page” ceased to be a link after installing your plugin.

    Apostol, when will you fix that bug?

    Thread Starter porton

    (@porton)

    Lucian, are you going to fix these bugs any time soon?

    If not, tell me to write a patch for you by myself.

    Plugin Author Lucian Apostol

    (@thedark)

    Hello.

    We are developing a new way of adding links that should solve this problem, and many others, but this will be released in the next major version, which may come in few months.

    Meanwhile, I am still trying to find a quick fix to it.

    Thread Starter porton

    (@porton)

    Lucian, it seems you need just to add check:

    el.closest("a") === null

    OK?

    Plugin Author Lucian Apostol

    (@thedark)

    The replacement for basic links (ones that you set up) is done via regular expressions in PHP. The version we are working on will add links by DOM-parsing instead. That’s why I said that this can be resolved when the new replacement engine comes out.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘It breaks existing links’ is closed to new replies.