Issues with Buddypress/Multisite

Try going roughly to line 406 in new-user-approve.php and adjust the code as follows:

// reset password to know what to send the user
			//$new_pass = wp_generate_password();
			$data = array(
				//'user_pass' => md5($new_pass),
				'user_activation_key' => '',
			);

This will prevent the plugin from creating a login for the registered and finally approved member. Hope this is helpful ??

Hi, Jason,

I just installed and tested this New User Approve plugin a few hours ago. I’m also using the BuddyPress plugin. For me, the New User Approve plugin sends an email, informing the admin to authorize, but the new registrant also gets a valid activation link without the admin authorizing first. But, as the new user, even after following the link to authorize the new registration, when trying to log in as the new user, the login fails to authenticate.

So, I peeked around in the new-user-approve.php file, and the only place I could find where the code fragment you supplied could go starts at line 450. After hacking in your code fragment, the finished function looks like this.

public function create_new_user( $user_login, $user_email, $errors ) {
		if ( $errors->get_error_code() ) {
			return;
		}

		// begin ckt  .............
		// create the user.  HACKED FOR BUDDYPRESS
		// $user_pass = wp_generate_password( 12, false );

		// reset password to know what to send the user
		$data = array(
			//'user_pass' => md5($new_pass),
			'user_activation_key' => '',
		);
		// ...........   end ckt

		$user_id = wp_create_user( $user_login, $user_pass, $user_email );
		if ( !$user_id ) {
			$errors->add( 'registerfail', sprintf( __( '<strong>ERROR</strong>: Couldn’t register you... please contact the <a href="mailto:%s">webmaster</a> !' ), get_option( 'admin_email' ) ) );
		}
	}

It’s too complicated to fully explain herein what the results were, different, of course, but after testing, it didn’t solve the problem. After testing failed to bring any joy, and upon further scrutinization of the new code in context, I am puzzled as to how it works/what it does, as I don’t see how the code fragment you have suggested makes us of the array “$data”. And, of course, commenting out the function call “wp_generate_password” does exactly that; no password is generated, (and no email is sent to the new registrant).

Not sure if this type of conversation is allowed in this forum. If it’s not, someone please inform me, and I will not do so again.

Update,

45 minutes after new user registration, (using code above), the “new user” did get a confirmation request notification email. Looks like my test email account at yahoo.com, is running exceptionally slowly today.

Jason, thanks for the reply. I am afraid that my version of new-user-approve.php has nothing that looks even remotely like the code you posted. The only instance of wp_generate_password is around line 460 and looks like this:

// create the user
		$user_pass = wp_generate_password( 12, false );
		$user_id = wp_create_user( $user_login, $user_pass, $user_email );
		if ( !$user_id ) {
			$errors->add( 'registerfail', sprintf( __( '<strong>ERROR</strong>: Couldn’t register you... please contact the <a href="mailto:%s">webmaster</a> !' ), get_option( 'admin_email' ) ) );
		}

I am using the newest 1.7.2.

Also, are there any plans to fix language recognition? After opening this thread, I actually noticed that language support (i.e. your plugin noticing the install language) is supposed to be working, but for me, it isn’t. I went to considerable lengths to try to make it happen, but no luck. Thanks again.

Unfortunately, multisite and buddypress is not yet supported. I’m hoping in the near future to add support for it.

As far as language updates, the plugin has changed so much since most of the translations were created that many of them are out of date. I am working on getting them updated with the help of the community.

I am not quite sure if I understand your reply – I thought you said I could fix the issue by editing new-user-approve.php? That would certainly be easy enough for me, it’s just that I can’t find the actual lines to supposedly edit.

As for language recognition, the actual problem I’m having is that language detection itself is broken. The plugin doesn’t recognize the language that is set in WordPress, and I couldn’t find a way to manually override the automatic choice, either.

Thanks!

If you would like to prevent the password from being sent use the new_user_approve_do_password_reset filter. https://github.com/picklewagon/new-user-approve/blob/master/new-user-approve.php#L491