• I am having lots of issues in 0.5.1 not working

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:295
    $lang is undefined

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:364
    lang is hard coded to de_DE

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:395
    $guild is not used

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:408
    $members could be null, need a check before you try foreach on it

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:463
    $raids could be null

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:468
    $bosses could be null
    $boss is not used

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:493
    $args is not used

    Lastly, and I can tell this is leftover from the older version
    Class methods should be declared with an access modifier

    I suggest making a method like this

    function getLang($lang) {
        return empty($lang) ? get_locale() : $lang;
    }

    and using $this->getLang() or $this->getLang($lang) whenever you need the language string

Viewing 2 replies - 1 through 2 (of 2 total)
  • Thread Starter 0sanity

    (@0sanity)

    wp-content/plugins/guild-armory-roster/WoWArmoryTable.php:410
    Lang is hard coded to de_DE

    Plugin Author bchristopeit

    (@bchristopeit)

    sorry for my late reply. I am not a programmer I try to fix stuff. If you wan`t you could download the 0.55 Version and send me the patch? Would be really helpfull ?? I only started to update this from the orignial to use it for my own guild ??

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Issues in 0.5.1’ is closed to new replies.