Issue with PHP 8.2

Hi @dsas22,

This error is coming from one of your snippets, not from the plugin. You’ll need to do a search for tax_display_cart to work out which ones have the outdated code.

Hi @dsas22,

In addition to what @bungeshea stated, this topic will give you enough information to solve your issue.

Best wishes!

Thanks for the replys! Do you mean the error comes from 1 of the snippets I added? How exactly can I look for the specific error. In the other link, where the problem is also described, it says to look in /wp-includes/functions.php. Isn’t this separate from the snippet plugin?

Hi Guys,

Thanks again for the explanation. I went through the topic, and it helped me with the solution. There was a snippet active with tax_display_cart which I changed toget_tax_price_display_modeAfter I changed this, I thought to upgrade to PHP 8.2 again.

Then I started testing again to see if the site was functioning. I noticed soon enough that the site crashed again at a certain action. So I started looking at the logs and came across the following.

thrown in /home/site01/public_html/wp-content/plugins/code-snippets/php/snippet-ops.php(582) : eval()’d code on line 39
[21-Jun-2024 15:08:02 UTC] PHP Warning: A non-numeric value encountered in /home/site01/public_html/wp-content/plugins/code-snippets/php/snippet-ops.php(582) : eval()’d code on line 39

Do you guys have any idea what this warning could be and where I should possibly look for it?

You’ll need to post the snippet code here if we are to look at it and find a solution.

How exactly can I look for the snippet where this problem occurs? After all, we have multiple snippets. Is there any way I could figure this out?

Anybody have any idea?

It’s tricky to say – there’s not a whole lot to go with in the error message you posted besides the bug occurs on line 39 of the snippet.

Could you try temporarily disabling each snippet and then activating one-by-one until you see the error pop up again?

I found out when upgrading to PHP 8.2 that there is an issue with 1 of the snippets that allows the sale price to be displayed in the checkout. When I deactivate the snippet, then the site works on PHP 8.2, and the plugin WooCommerce Force Sells plugin works again. When I then reactivate the snippet, the site breaks down. See also the snippet code php below. Is there anything displayed in the code that is not correct on PHP 8.2?

/**
 * Show sale prices at the checkout.
 */
function my_custom_show_sale_price_at_checkout( $subtotal, $cart_item, $cart_item_key ) {

	/** @var WC_Product $product */
	$product = $cart_item['data'];
	$quantity = $cart_item['quantity'];

	if ( ! $product ) {
		return $subtotal;
	}

	$regular_price = $sale_price = $suffix = '';

	if ( $product->is_taxable() ) {

		if ( 'excl' === WC()->cart->get_tax_price_display_mode ) {

			$regular_price = wc_get_price_excluding_tax( $product, array( 'price' => $product->get_regular_price(), 'qty' => $quantity ) );
			$sale_price    = wc_get_price_excluding_tax( $product, array( 'price' => $product->get_sale_price(), 'qty' => $quantity ) );

			if ( WC()->cart->prices_include_tax && WC()->cart->tax_total > 0 ) {
				$suffix .= ' <small class="tax_label">' . WC()->countries->ex_tax_or_vat() . '</small>';
			}
		} else {

			$regular_price = wc_get_price_including_tax( $product, array( 'price' => $product->get_regular_price(), 'qty' => $quantity ) );
			$sale_price = wc_get_price_including_tax( $product, array( 'price' => $product->get_sale_price(), 'qty' => $quantity ) );

			if ( ! WC()->cart->prices_include_tax && WC()->cart->tax_total > 0 ) {
				$suffix .= ' <small class="tax_label">' . WC()->countries->inc_tax_or_vat() . '</small>';
			}
		}
	} else {
		$regular_price    = $product->get_price() * $quantity;
		$sale_price       = $product->get_sale_price() * $quantity;
	}

	if ( $product->is_on_sale() && ! empty( $sale_price ) ) {
		$price = wc_format_sale_price(
			         wc_get_price_to_display( $product, array( 'price' => $product->get_regular_price(), 'qty' => $quantity ) ),
			         wc_get_price_to_display( $product, array( 'qty' => $quantity ) )
		         ) . $product->get_price_suffix();
	} else {
		$price = wc_price( $regular_price ) . $product->get_price_suffix();
	}

	// VAT suffix
	$price = $price . $suffix;

	return $price;

}
add_filter( 'woocommerce_cart_item_subtotal', 'my_custom_show_sale_price_at_checkout', 10, 3 );

It seems like the value of your $quantity variable is coming in as a string or similar, which isn’t working when you multiply it out on lines 39-40 – either that, or $product->get_price() or $product->get_sale_price() is giving you something non-numeric.

If possible, it might be worth adding some echo statements in your code so you can see what values are actually being provided to you there. If I had to guess, I’d say that $cart_item['quantity'] might be giving you an empty string, which is causing the multiplication to fail. If that’s the problem, a fix might be replacing this line:

$quantity = $cart_item['quantity'];

with this:

$quantity = is_numeric( $cart_item['quantity'] ) ? $cart_item['quantity'] : 0;

Hello Shea, thank you for your message. I have replaced the lines. After replacing them, I am still experiencing the problem. The WooCommerce Force Sells plugin does not work then. When the force sell is on for a specific product, and you add the product to the cart, it keeps loading. Thereby again, when I deactivate the snippet code I can add something to the cart where the force sell is on.

Do you know if there is another code I can use to display the sale price in the checkout page? Maybe I should try something else.

/**
 * Show sale prices at the checkout.
 */
function my_custom_show_sale_price_at_checkout( $subtotal, $cart_item, $cart_item_key ) {

	/** @var WC_Product $product */
	$product = $cart_item['data'];
	$quantity = is_numeric( $cart_item['quantity'] ) ? $cart_item['quantity'] : 0;

	if ( ! $product ) {
		return $subtotal;
	}

	$regular_price = $sale_price = $suffix = '';

	if ( $product->is_taxable() ) {

		if ( 'excl' === WC()->cart->get_tax_price_display_mode ) {

			$regular_price = wc_get_price_excluding_tax( $product, array( 'price' => $product->get_regular_price(), 'qty' => $quantity ) );
			$sale_price    = wc_get_price_excluding_tax( $product, array( 'price' => $product->get_sale_price(), 'qty' => $quantity ) );

			if ( WC()->cart->prices_include_tax && WC()->cart->tax_total > 0 ) {
				$suffix .= ' <small class="tax_label">' . WC()->countries->ex_tax_or_vat() . '</small>';
			}
		} else {

			$regular_price = wc_get_price_including_tax( $product, array( 'price' => $product->get_regular_price(), 'qty' => $quantity ) );
			$sale_price = wc_get_price_including_tax( $product, array( 'price' => $product->get_sale_price(), 'qty' => $quantity ) );

			if ( ! WC()->cart->prices_include_tax && WC()->cart->tax_total > 0 ) {
				$suffix .= ' <small class="tax_label">' . WC()->countries->inc_tax_or_vat() . '</small>';
			}
		}
	} else {
		$regular_price    = $product->get_price() * $quantity;
		$sale_price       = $product->get_sale_price() * $quantity;
	}

	if ( $product->is_on_sale() && ! empty( $sale_price ) ) {
		$price = wc_format_sale_price(
			         wc_get_price_to_display( $product, array( 'price' => $product->get_regular_price(), 'qty' => $quantity ) ),
			         wc_get_price_to_display( $product, array( 'qty' => $quantity ) )
		         ) . $product->get_price_suffix();
	} else {
		$price = wc_price( $regular_price ) . $product->get_price_suffix();
	}

	// VAT suffix
	$price = $price . $suffix;

	return $price;

}
add_filter( 'woocommerce_cart_item_subtotal', 'my_custom_show_sale_price_at_checkout', 10, 3 );