Issue with Contact Card in footer

  • Resolved therealgilles

    (@chamois_blanc)


    3 years, 2 months ago

    With a recent plugin update, the legacy widget Contact Card in the footer now displays HTML as text:

    <div id="bpfwp_contact_card_widget-8" class="footer-widget widget wpex-pb-40 wpex-clr widget_bpfwp_contact_card_widget"><div class="widget-title wpex-heading wpex-text-md wpex-mb-20">Location</div>
...
</div>

    The non-legacy widget Contact Card works but is missing the title option.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter therealgilles

    (@chamois_blanc)

    The issue is due to these changes:

                    public function widget( $args, $instance ) {
-                       echo $args['before_widget'];
+                       echo esc_html( $args['before_widget'] );^M
                        if ( isset( $instance['title'] ) ) {
                                $title = apply_filters( 'widget_title', $instance['title'] );
-                               echo $args['before_title'] . $title . $args['after_title'];
+                               echo esc_html( $args['before_title'] . $title . $args['after_title'] );^M
                        }
 
                        echo bpwfwp_print_contact_card( $instance );
-                       echo $args['after_widget'];
+                       echo esc_html( $args['after_widget'] );^M
                }
    Thread Starter therealgilles

    (@chamois_blanc)

    It would also be great if the code did not include ^M characters.

    Same issue here on all my sites. Here is a short screen grab from the front and back end.

    https://somup.com/c3VqoNZTwZ

    As @chamois_blanc mentions, the non legacy widget works but I don’t want to use that one because it doesn’t have a title and I don’t want to go in all my sites to replace the widget.

    Thanks
    JP

    Same here, legacy widget broken on about 1200 client sites, and fix would be much appreciated, I echo @jpnl ?? Many thanks!

    We are facing the same issue on our 100+ client sites. We rolled back to a previous release but a fix is needed.

    • This reply was modified 3 years, 2 months ago by OYM.
    • This reply was modified 3 years, 2 months ago by OYM.
    Plugin Support jaysupport

    (@jaysupport)

    Hi all,

    Thank you for reporting this. We’ve just released an update to fix this issue with the widget output, which was related to the recent escaping updates.

    Thank you for the quick fix!

    Thread Starter therealgilles

    (@chamois_blanc)

    Thank you for the fix!

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Issue with Contact Card in footer’ is closed to new replies.