Issue on form submit with V5

I’m really sorry about that!

The new terms toggle broke yesterday after adjusting something with the conditional checkboxes in the plugin settings shortly before release. It should be fixed in v5.0.2

When will the updated v5.0.2 be available?

All right, thank you for your answer ??
Great job on the V5 btw !

It should already be available.

Thanks @nartoof, release days are stressful!

Sure it is…

But no worries, we also got a lot of work now to update our websites ^^ (CSS class changed, deprecated hooks, shortcode updates)…

Have a nice day anyway ??

It’s all right V5.0.2 fix it ! Thanks again !

@nartoof Please make sure to read the Upgrade Guide (which you can access on the Site Reviews Help page) if you previously have been using any hooks or custom changes on Site Reviews. A few things have changed, but for the most part everything should be backwards compatible.

Yep I read it and update 5 websites using your plugin this morning. Everything works fine, no problem ??

The only problem I had is that you now use esc_html__ on the terms label and I used to display a link to the website privacy policy.

But problem fixed with a filter !

Ah, thanks for catching that! I’ll change it back in the next update to you can add link in the terms translation.

Oh thanks ?? I thought it was a security choice ! ^^

Because we are speaking, I remember a problem I got with your plugin when I want to defer JS on wordpress. I use this filter :

function MSW_defer_parsing_javascript ( $url ) 
{
	if ( FALSE === strpos( $url, '.js' ) ) return $url;
	if ( strpos( $url, 'jquery.js' ) ) return $url;
	return "$url' defer ";
}
add_filter( 'clean_url', 'MSW_defer_parsing_javascript', 11, 1 );

I need to add :

if ( strpos( $url, 'site-reviews.js' ) ) return $url;

Because your JS frontend file return 404 with this filter if I don’t add this line…

Do you have any idea why ?

It’s because you are assuming that the URL is surrounded by single quotes "$url' defer ";. Site Reviews likely uses double quotes in which case it would be this: $url.'" defer ';

With Site Reviews, there is actually an easier way to do this:

add_filter('site-reviews/defer-scripts', function ($scripts) {
    $scripts[] = 'site-reviews';
    return $scripts;
});

@nartoof Please update to v5.0.3

Thank you for the update ! It seems you worked hard since two days there is an update every 3 hours xD

And thank you for the filter, I’ll use it to parse your JS files on frontend ! ??