Issue during cron execution – not acceptable

  • Resolved lolitsjohnnyboy

    (@lolitsjohnnyboy)


    3 years, 7 months ago

    I’ve found an issue which is absolutely not acceptable! An important plugin uses the URL parameter action=run-cron as well. When I trigger an action on the specific plugin (not your plugin) page, your code throws an issue:

    PHP Notice: Undefined index: sig in /Users/xxx/Sites/localhost/wp-content/plugins/wp-crontrol/wp-crontrol.php on line 581

    This issue happens because you are listening for $_GET['action'] globally. Instead, you should first check if the action is triggered within your plugin page by checking for $_GET['page'] === 'crontrol_admin_manage_page' && .....!

    Until this is fixed, I need to disable the plugin.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author John Blackbourn

    (@johnbillion)

    WordPress Core Developer

    This has been fixed in version 1.11.0.

    A word of advice: don’t use language like “absolutely not acceptable” when you’re talking to the author of an open source plugin which is provided to you for free. It doesn’t go down well.

    Thread Starter lolitsjohnnyboy

    (@lolitsjohnnyboy)

    I can understand your point of view but as a developer I see more and more plugins that are badly programmed which produces more issues instead of helping someone. What I’m missing here is something like a quality gate which prevents at least some basic issues…

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Issue during cron execution – not acceptable’ is closed to new replies.