Instead of review (for now)
-
First off, congratulations to your one-of-a-kind labor of love plugin! Just short of a thousand options, no one is going to attempt to beat you there. ??
Must have taken you a lifetime to code this. It surely took me half a lifetime to go through the options, lol. Let’s share a good laugh, shall we? ??Why I’ve put the review on hold: I’d like to give your plugin high five later, and give you sth much more valuable immediately: detailed feedback/suggestions.
For a start (cause I am starting with the plugin too):
1) All your ? and sometimes ! help texts are coded to come up with the website’s popup alert box, correct? This permanent clicking to get the box away is…. nerve-wrecking. And if you felt “you don’t need to click to open help in the first place” then I’d counter “if the help texts weren’t needed why have them there?” ??
So, all other plugin authors (I know of) use different ways for help texts, none uses those popup alerts. I’d guess the most user-friendly way is how Michael Torbert with his very mature “All in One SEO” does it:
– a question mark, tagged “Click for help”
– you have to click it too, yes
– but: the help text shows up right underneath/next to it
– this is clever AND user-friendly because:
– the second-best way (show help on hover) does not allow:
– putting links in
– letting users open up all comments and do a ctrl-f page search ??(the “open up ALL comments” is a hint: even he doesn’t have that extra button yet, but should)
2) The current popup alert box code is flawed anyway (I won’t say “error” as I can’t assess that): During the “getting to know wppa+” period … I have the “Settings” page open all the time of course, fully expanded each section, for the reason/tip just mentioned.
And permanently the browser forces me back to the settings page because that alert box popped up AGAIN saying “[website name] says: undefined”.
It doesn’t even say WHAT is “undefined”, so it’s an entirely useless and annoying flaw. Enough said. ??3) I do NOT suggest you reorganize all settings (and make them consistent, at the moment many references don’t even match your newest table organization…).
Why NOT suggest it?
A more systematic and intuitive and consistent structure would surely benefit your plugin yes, but: it would waste your time. I don’t want that. Leave that.4) However, what I would suggest: Get rid of all those “options” that you yourself say “strongly discouraged” and such.
Why waste your (and our) time?(unless of course, you aimed to win the wp prize for the plugin with the most options? I doubt that)
More to come.
I trust you notice I am trying to help, not criticize. Where it sounds like that, it’s just funny to make it “stick”. ??
Again, thank you for an amazing labor of love plugin!
-
Discovered a security issue (among other new things):
When ticked, your whole default javascript/jquery code shows up in description field, surely no one should see the default CODE in my opinion. (not even sure why a default description needs code…)You may enter html in the description field if it is enabled in Table IX-B1.
If you do not want that, untick IX-B1. The default shows some example html that shows a table with some camera settings (exif data).I also just remember that after adding an album fe, one can’t read anything: it seems new album links/names(?) get written at the same place as prior ones… All over each other.
Can not reproduce this. If you do this on an album cover, it will create a sub-album.
So, the admin should decide either if he wants a standard description (including automatically filled in exif data like the example, See Table IX-D3) that needs the permissions to have html code in it, and NOT the option for the user to overwrite it (Table II-H9)
OR
Enable user fillable description (Table II-H9, optionally mandatory(!)), and disallow html in Table IX-B1 if he finds that this could be a security risk.
- The topic ‘Instead of review (for now)’ is closed to new replies.
