• Resolved CoolDavidoff

    (@cooldavidoff)


    First off, congratulations to your one-of-a-kind labor of love plugin! Just short of a thousand options, no one is going to attempt to beat you there. ??
    Must have taken you a lifetime to code this. It surely took me half a lifetime to go through the options, lol. Let’s share a good laugh, shall we? ??

    Why I’ve put the review on hold: I’d like to give your plugin high five later, and give you sth much more valuable immediately: detailed feedback/suggestions.

    For a start (cause I am starting with the plugin too):

    1) All your ? and sometimes ! help texts are coded to come up with the website’s popup alert box, correct? This permanent clicking to get the box away is…. nerve-wrecking. And if you felt “you don’t need to click to open help in the first place” then I’d counter “if the help texts weren’t needed why have them there?” ??

    So, all other plugin authors (I know of) use different ways for help texts, none uses those popup alerts. I’d guess the most user-friendly way is how Michael Torbert with his very mature “All in One SEO” does it:
    – a question mark, tagged “Click for help”
    – you have to click it too, yes
    – but: the help text shows up right underneath/next to it
    – this is clever AND user-friendly because:
    – the second-best way (show help on hover) does not allow:
    – putting links in
    – letting users open up all comments and do a ctrl-f page search ??

    (the “open up ALL comments” is a hint: even he doesn’t have that extra button yet, but should)

    2) The current popup alert box code is flawed anyway (I won’t say “error” as I can’t assess that): During the “getting to know wppa+” period … I have the “Settings” page open all the time of course, fully expanded each section, for the reason/tip just mentioned.
    And permanently the browser forces me back to the settings page because that alert box popped up AGAIN saying “[website name] says: undefined”.
    It doesn’t even say WHAT is “undefined”, so it’s an entirely useless and annoying flaw. Enough said. ??

    3) I do NOT suggest you reorganize all settings (and make them consistent, at the moment many references don’t even match your newest table organization…).
    Why NOT suggest it?
    A more systematic and intuitive and consistent structure would surely benefit your plugin yes, but: it would waste your time. I don’t want that. Leave that.

    4) However, what I would suggest: Get rid of all those “options” that you yourself say “strongly discouraged” and such.
    Why waste your (and our) time?

    (unless of course, you aimed to win the wp prize for the plugin with the most options? I doubt that)

    More to come.

    I trust you notice I am trying to help, not criticize. Where it sounds like that, it’s just funny to make it “stick”. ??

    Again, thank you for an amazing labor of love plugin!

Viewing 15 replies - 1 through 15 (of 24 total)
  • Plugin Author Jacob N. Breetvelt

    (@opajaap)

    Thank you for your review. It is most appreciated. Especially issues that affect user friendlyness are very welcome. I am developing this for only just over 8 years now, and believe me, all settings: either i needed them myself, users asked for it or they were needed to avoid conflicts with certain themes or plugins.

    As you noticed: there are references that point to the worng setting, due to reorganisations in the past. If you can name any of those inconsistencies, please tell me, i will be pleased to fix them.

    Settings often belong to two ore more topics, so, to orginize them in a logical way – i.e. to convert a multi-dimensional matrix into a flat table – is very complex and not a straightforward thing to do, but i am aware of it. This is why you can select up to two keywords near the top of the page to show all related settings.

    Funny but a few hours ago, i think approx when you edited the above, i finally digged into the code to find the cause (or causes) of the annoying ‘Undefined’ alert box. I hope, and i think, it should be fixed by the next minor update.

    A related topic is that when you run a maintenance proc interactively (Table VIII Start! buttons) and a server error occurs, you will see an confirmationbox asking you if you want to continue. You want, so in the next version you will only see an alertbox after 10 server errors, so the maintenance procedure will almost aways continue on a hidden browser tab without the confirmation box.

    Your suggestion on displaying helptexts differently is very usefull. I do hardly need any helptexts as you will understand, so – like what i said about userfreindlyness – applies here too. I will see what i can do on this topic for the upcoming fix release. Pls stay tuned…

    For a ‘newby’ it should be sufficient to answer the 16 questions in Table 0: Quick setup, and playing around on https://wppa.nl

    Always open to usefull suggestions.

    PS: A [!] button as opposed to [?] for the helptext means: your setting is NOT the default.

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    Thanks so much for your response Jacob, and so fast I can’t keep up.

    I maintain you really need not waste time on correcting older references and on a more “ergonomic” way for the options.
    But since you asked I now can’t pull out, so I have indeed started a list of whatever I came across since then. No wrong references yet, sorry, but if the following can help you in any way I’d be glad I took the effort (and continue to take) as your effort is so much bigger:

    wppa+ notes
    ————-
    – where: <input style=”/*! width:100%; */margin-top:8px;margin-bottom:8px;padding-left:0;padding-right:0;” id=”wppa-user-upload-11-1-display” class=”wppa-upload-button” value=”Select Photos / Camera” onclick=”jQuery( ‘#wppa-user-upload-11-1’ ).click();” type=”button”>

    … the buttons and input fields all span across 2000px on large screens! Either do not “overwrite” one’s standard button and input css at all, or delete “width:100%” (or set it to auto) and give padding a value of 20px or what you want.
    – same with textarea styling overwrite
    – also there are a LOT of “invalid property values” anyway, eg:
    – style=”border:1 px solid #bbbbbb; Should be: 1px, no space.
    – khtml-border-radius: 6px;
    – -moz-border-radius: 6px;
    … Use Inspector? Helps me a lot.

    – placing widgets on pages instead into sidebar (even only to see what the widgets would do) is not easy. For SOME widgets your docu mentions the alternative shortcode we can use to get the same/similar output. Could you docu more generally on your shortcodes page for the other widgets too?
    – Because: sidebars is old, most got rid of that (responsiveness etc). Today we need to be able to put shortcodes right inside pages/posts.

    – maybe could you put a search on your site?

    – table 2C4 is not high enough for fb buttons to display fully even when only 20*20; table 1C4 and 4a have no impact

    – in upload box: put image types allowed
    – max upload size: let us choose! on web, camera photo sizes make no sense anyway, smaller is best! (unless photographer/sale)
    – when photo upload too big, it keeps green “Done!” but should say red “Failed!”
    – “Upload Photo” should only be clickable once: i hit it multiple times, and the processing never stopped….
    – should also have Cancel button, was needed in my test case already.
    – we should be able to make fields mandatory to be filled before one can click upload?
    – on successful upload (particularly if only one photo allowed), there should be a link to the photo, or to the album, or the photo or album itself be shown; at the moment, nothing. it stays with the green “done”
    – Table II-D19 Select the location of the upload and create links: “At the bottom”. ?? I do not understand anything here? Do you?
    – user upload video and audio: may I suggest to replace that (or at least offer alternative) to let users enter youtube link (and use its thumb in your filmstrip etc)? Google “wordpress serving video” etc to see that it’s a no-no. Hence why plugins that do, offer to set up a cdn.
    All too much trouble for most though! Much easier: offer “enter link” (alternative at least) ?

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    Oh and Jacob, where you auto-create albums for users logged in,
    when they click on their name link, it says “No albums or photos found matching your search criteria.”
    And even after they upload a photo, it neither is put in their album nor does it appear replacing their named link.

    Or does the plugin admin need to do sth about your autocreated albums? I can’t see what, on your site here? https://wppa.nl

    No worries though, I gonna figure it all out, if it’s meant to work auto.

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    <input style=”/*! width:100%; */margin-top:8px;marg ….

    Please never ever modify plugin code, if you want something that needs code change, i will do it in a way to preserve backward and forward compatibility.
    Changes you made yourself will be lost at an update.

    Add to Table IV-A15 (Custom style):

    .wppa-upload-button {
    width: auto !important;
    padding-left:20px;
    padding-right:20px;
    }
    

    do not “overwrite” one’s standard button and input css at all

    This would really lead to incredible bad layouts on many themes…

    there are a LOT of “invalid property values”

    Pls supply links to pages where you find this.
    I use the console on firefox that tells me the errors and i can only fix errors i see…

    Almost all widgets have their ‘box’ alternative. If you miss one, pls tell me.

    On the https://wppa.nl homepage, there is a search box right below the paypal button.
    Enter e.g. bestof and you will get a list of topic exerpts, including a page that describes the ‘bestof’ feature, as box and as widget.

    – table 2C4 is not high enough for fb buttons to display fully even when only 20*20; table 1C4 and 4a have no impact

    I just verified that it works like expected. See:
    https://wppa.nl/screenshots/wppaspec/oc1/cv0/ab99/pt4773

    – in upload box: put image types allowed

    That is a good idea.

    – max upload size: let us choose! on web, camera photo sizes make no sense anyway, smaller is best! (unless photographer/sale)

    The default max upload size is defined by the server memory available needed to downsize/create thumbnail. This is meant to inform the user that IF he uploads a larger image it is likely that the upload will fail due to a server error.
    If you want, you can set a smaller max size – and even min size – in Table VII-B10.1 and 10.2. There will be an errormessage if you attempt to upload outside this range.

    – when photo upload too big, it keeps green “Done!” but should say red “Failed!”
    – “Upload Photo” should only be clickable once: i hit it multiple times, and the processing never stopped….
    – should also have Cancel button, was needed in my test case already.
    – we should be able to make fields mandatory to be filled before one can click upload?

    I will get into these.

    – on successful upload (particularly if only one photo allowed), there should be a link to the photo, or to the album, or the photo or album itself be shown; at the moment, nothing. it stays with the green “done”

    VII-B11 allows you to link to the front-page after successful upload. One can not link to a photo or an album, one can only link to a post or page.
    Use the upload dialog on album covers or on the thumbnail area: Table II-D19. Using this will reload the page with the updated album content.
    Note: the visitor must have upload accees rights (is the owner, or the owner of the album is —public—) to the album for the upload dialog to show up.

    Much easier: offer “enter link” (alternative at least)

    NO! wppa is a cms. It will only show its own content.

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    There must be more photos than the treshold number in Table I-A4. Set I-A4 to 0
    Or tick II-D18

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    Did you register on https://wppa.nl ?
    If so, visit https://wppa.nl/members/

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    I never ever modify plugin code. Why should I?

    You misunderstood. The code I pasted straight from how your code comes up in Inspector. Lots and lots of warnings/errors.
    For once I am really not at fault, lol.
    Don’t feel upset, you asked for details so I thought you wanted them.

    (what i do do is I ADD css into “custom css” field of Sayontan’s evergreen best theme Suffusion. You can’t complain I do)

    “Pls supply links to pages where you find this.
    I use the console on firefox that tells me the errors and i can only fix errors i see…”
    I did. And I used firefox too, but it’s called inspector at my end.
    If you want, go through key pages created by your plugin on YOUR site, Inspector open, and you will see all the orange and red marks.
    I am not criticizing at all, hope you didn’t misunderstand all my effort?

    “Add to Table IV-A15 (Custom style):” No I won’t: Like I said it’s more than that button that your plugin’s styling makes laid out horribly. You just don’t do buttons width 100%, it’s crazy, ask others if you don’t like me saying ??

    “Almost all widgets have their ‘box’ alternative” – that bit i don’t understand, but never mind, i gonna see it…

    “On the https://wppa.nl homepage, there is a search box right below the paypal button.” No, it’s only on your start page. ALL the ones in your looooong list Pages Menu have neither, eg here https://wppa.nl/docs-by-subject/admin-pages/upload-photos/

    “I just verified that it works like expected.” No it doesn’t, you tried a different page/shortcode ??

    “in Table VII-B10.1 and 10.2.” I didn’t use that because it isn’t clear: width AND height, but just one input field. And I didn’t mean that anyway, I meant: don’t even tell users what OUR server MIGHT accept as max. It’s none of anyone’s business. Plugin users should (be able to) define max values. Always. I don’t know of any other plugin that simply copies and uses values found for the server. Whatever. Was just my tip, forget it then.

    “One can not link to a photo or an album, one can only link to a post or page.” Understood, thank you!

    “Table II-D19. Using this will reload the page with the updated album content.” No it did not, just green button, no change. But I don’t care, no worries.

    “NO! wppa is a cms. It will only show its own content.” LOL misunderstood! wp itself is a cms right?
    Google what I said, video uploads and play via wp are £^&”%E”^”(

    I would ABSOLUTELY vote for allowing users to enter a youtube link or what, like they enter a photo name and what. I bet EVERY plugin tester will. Take my bet?

    “There must be more photos than the treshold number in Table I-A4. Set I-A4 to 0”
    I have that yes: “0 must always show” or so (can’t copy from those damn alert boxes ^£(*$&$Y)

    Hey, don’t misunderstand. I thought you wanted detailed feedback. Leave the plugin like it is. It must be like hot pancakes for the huge photographers sector etc. They’ll love all those options!

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    I forgot to mention one more thing I noticed in your fantastic plugin wppa+ Jacob:
    Currently it seems it creates a new default album for every login? I noticed five additional “default” albums for me…

    What you probably wanted with table 9 D 9 is, the FIRST time a user logs in?
    But there’s no limit yet.

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    I thought you wanted detailed feedback. Leave the plugin like it is.

    Yes, i am really very glad with all your remarks, and i will help you wherever i can, and i will fix any bug.

    Today i will try to simulate your problems (that i do not have, like the multiple user albums created and the thumbnail frame size issue) on your theme Suffusion.

    In the mean time i found 5 locations of 1 px solid that will be fixed asap. Thanx again.

    Try theme Twentysixteen (the theme of wppa.nl) without wppa activated and see the very many css warnings in the firefox console. They are from the theme, not from my plugin.
    I will remove all references to -moz-xx -webkit-xx and -khtml, as they should be obsolete by now.

    To be continued

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    Oh just a quick sorry then: Yes you are right, likely the new default albums for every login aren’t caused by your plugin (you would have noticed). Maybe they are caused by someone’s specific implementation? Like say, we have the very powerful s2member plugin that may well affect lots of stuff to safeguard the site (Jason is a genius programmer too!) But I cannot imagine it’s theme related as themes normally don’t change plugins, I think. Sayontan is another of those, very very few, genius programmers!

    You see we only get the best, what a complement for you Jacob ??
    (they both got tons of valuable feedback from me too, nothing personal)

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    Pls tell me your setings of Table IX-D
    9 Grant an album Create an album for each user logging in.
    10 Grant album name The name to be used for the album.
    11.0 Grant parent selection method The way the grant parents are defined.
    11.1 (depends of 11.0)

    I can not reproduce the multi album issue even with s2member activated.
    I really want to know how you managed this, to be able to prevent it in future situations.

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    9 ticked
    10 display name
    11 an album multiselectionbox (left it, no idea: not explained)
    like you, members

    I can not reproduce the multi album issue
    Oh, odd! Don’t waste your time then!! Until someone else reports it?

    (got an idea: then it “must” be caused when we (admin) make many settings changes during testing/learning???)

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    This should never happen. Even when it is due to a mis-configuration.
    If you have this on a testsite and you want me to look into it, you can mail me directly to give me admin rights: opajaap at opajaap dot nl

    Plugin Author Jacob N. Breetvelt

    (@opajaap)

    I studied the source code around creating granted albums, but i really can not imagine how you managed it to get it creating an album on every pageload. I really would like to see all your settings and the entire album table from the Album Admin menu.
    If you run Table VIII-A2, it will create file
    .../wp-content/wppa-depot/{yourusername}/settings.bak
    In Table XII you can download wp_wppa_albums.csv
    Please mail me the files. Mail to: opajaap at opajaap dot nl
    BTW: there is a simple ‘Remove all empty albums’ tool: Table VIII-B7

    Please read this ducumentation page and install the current dev version 6.8.01.Beta.008 to enjoy the changes i made to the settings page and the front-end upload dialog. There should (?) be no possibility that the process dies without any human understandable notice…

    Table IX-D11.1 is a selectionbox where you can select one or more albums that should be the parent album(s) for the auto created user albums (ONE per user under each parentalbum).

    On my dev site https://beta.opajaap.nl i installed and activated Suffusion 4.4.9 and ticked the box Enable responsive layouts on the layouts tab, but resizing the browser window does not show any responsiveness…

    Thread Starter CoolDavidoff

    (@cooldavidoff)

    You did sth wrong then, suffusion was already fully responsive when other themes didn’t even know what “responsive” means….

    And I didn’t say on every pageload! I clearly said on every login. I had FIVE default albums for me…

    Like I said countless times Jacob, please DON’T waste your time on unimportant things. You get a five star review ANYWAY. I just have to finish testing at some point (too busy now).

    No, I do not do betas. Never.
    Sorry if that disappoints you in any way. Everyone has their own principles.

    “Table IX-D11.1 is a selectionbox where you can select one or more albums that should be the parent album(s) for the auto created user albums (ONE per user under each parentalbum).”
    Thanks for that. (I still don’t understand “multiple parents”, but that’s just me, don’t you worry!) ??

Viewing 15 replies - 1 through 15 (of 24 total)
  • The topic ‘Instead of review (for now)’ is closed to new replies.