Inline All CSS Feature not working after 4.1.0 update (v2)

@technicalx can you send me the website address?

Not sure if you ever got this figured out, but I was the one that posted the original “Inline All CSS Feature not working after 4.1.0 update”. After talking with the optimocha dev, we found out that the features worked if I disabled my SEO plugin. so we assumed it was just the SEO plugin causing issues. However, I later realized that with the default 2021 theme and that same SEO plugin, the speed booster features were working. So I dug through 2021’s functions file to find what was allowing speed booster to work on 2021, but not my theme. After going line by line I found the one simple line that fixes the problem. Just add this to your themes functions file and speed booster should work.

add_theme_support( 'title-tag' );

Doesn’t fix it, I have no other plugins installed.
Same problem in 2015 template too.
my only non-standard setup is having websites in subdirectories

Only error I get is this
Trying to access array offset on value of type null in =/home/dev/public_html/network/wordpress_test2021/wp-content/plugins/speed-booster-pack/includes/classes/class-sbp-cloudflare.php= on line 115

Ah. I’m not using any of the CDN settings, so I have not encountered this issue. If you disable the CDN features does it work?

I just tried Reset, Caching On, Inline All, Minify Inlined on 2020 theme and doesn’t work. No CDN.

actually just noticed another bug, that Inline All enabled changes the Title tag encoding to unencoded.

Website Title with Inline All disabled
empty &_amp; 2021 &_#8211; essential plugins
website title after Inline All enabled (which is wrong)
empty & 2021 – essential plugins

edit: can’t show proper entities here so ignore the underscore.

• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.

I just installed a fresh WordPress (AU version) in a subdirectory, new database utf8mb4_unicode_ci, Speed Booster plugin, Permalinks on, caching on, inline on – doesn’t inline.

• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.

@technicalx can you install the Autoptimize plugin and enable the “Inline all CSS” option, and see whether or not it works? I can’t log in with the credentials you provided anymore.

Now using 4.1.1 speed booster pack.

Yes autoptimize Inline All CSS works.

In speed booster pack 4.1.1
Title tag encoding is also messing with other titles in page too, so entities in both <title> and <h1> site title and <h2> page titles etc are all being decoded to plain characters when the plugin has Inline CSS enabled – but NOT when that part is disabled.
I’m not sure if that is related to the Inline CSS failing, but it’s not good.

Hi @technicalx,

Can you navigate to line 223 in the file /speed-booster-pack/vendor/simplehtmldom/simplehtmldom/HtmlDocument.php and and change that line from this:

$this->decode();

to this:

// $this->decode();

And tell me if anything good happens? It will fix the decoding issue but I’m wondering if it will fix CSS inlining as well.

• This reply was modified 3 years, 9 months ago by Optimocha.

That fixes the characters but still no inline CSS.

Also wondering why JS Defer for inline JS is base64 ? base64 is bigger in all my inline JS by about 30% which is close to what they say about base64 conversion.
includes\classes\class-sbp-js-optimizer.php line 183 should probably just disable this until there’s a toggle flag to enable it and a strategy to remove whitespace from JS would be better but that’s always risky and might as well leave it to autoptimize.

• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.
• This reply was modified 3 years, 9 months ago by technicalx.

@technicalx that behavior of encoding inline JS has to be done in order to prevent screwing up JS execution order; otherwise inline JS can’t be deferred with the defer parameter and JS files load & execute after inline JS, causing all sorts of JS errors. I highly recommend you don’t comment out that line (183) because you’ll most likely break your JS.