Incorrect text domain for certain strings

  • Resolved lpdsgn

    (@lpdsgn)


    1 year, 1 month ago

    Hi, first of all I want to congratulate you on the plugin, I use it on a customer’s e-commerce site and we are satisfied.

    I wanted to let you know that I noticed an incorrect compilation of the text domain in the plugin files for some strings.

    The text domain loaded by class-woocommerce-gift-cards-lite-i18n.php is woo-gift-cards-lite, but in some files the strings use the giftware text domain instead.

    I noticed this because I translated some strings with the Loco Translate plugin and I didn’t see the text in the corresponding language on front-end.

    At the moment I can tell you that I have identified the second giftware text domain in the class-woocommerce-gift-cards-lite-public.php file, lines 2254-2336.
    I don’t know if it is used in other files too.
    Temporarily, I’ve manually updated the text-domain of those strings that interest me directly in the php file.

    Could you standardize the text domain – or register both – in the next plugin release? In this way the implemented translations will work effectively, and there is no risk of losing them in case of updating your plugin.

    Thanks a lot, and good job again ??

    • This topic was modified 1 year, 1 month ago by lpdsgn. Reason: updating mentioned lines of code
Viewing 1 replies (of 1 total)
  • Plugin Author WP Swings

    (@wpswings)

    Hello,

    Thank you for choosing our plugin! We’re delighted to hear that our plugin is assisting you and that you are pleased with its features and functionality.
    And thanks for pointing out the issue our team is working on it soon we will release our update with this fix.

    Regards,

Viewing 1 replies (of 1 total)
  • The topic ‘Incorrect text domain for certain strings’ is closed to new replies.