Imagebrowser stopped working

@sirion89 – You noted you have made some customizations, I would suggest looking at that code first …

– Cais.

It worked before the update so i dont think the code we added is a problem at all. It looks like more about the generated link for the pic inside the gallery and none of our customization touch that, we kept your default code for that part.

<?php for ($i=0; $i<count($images); $i++):
           $image = $images[$i];
           $thumb_size = $storage->get_image_dimensions($image, $thumbnail_size_name);
           $style = isset($image->style) ? $image->style : null;

           if (isset($image->hidden) && $image->hidden) {
              $style = 'style="display: none;"';
           }
           else {
                $style = null;
           }

                 $this->start_element('nextgen_gallery.image_panel', 'item', $image);

                ?>
                <div id="<?php echo_h('ngg-image-' . $i) ?>" class="ngg-gallery-thumbnail-box" <?php if ($style) echo $style; ?>>
                    <?php

                    $this->start_element('nextgen_gallery.image', 'item', $image);
                    ?>
                    <div class="ngg-gallery-thumbnail">
                        <a href="<?php echo esc_attr($storage->get_image_url($image, 'full', TRUE))?>"
                           title="<?php echo esc_attr($image->alttext)?>"
                           data-src="<?php echo esc_attr($storage->get_image_url($image)); ?>"
                           data-thumbnail="<?php echo esc_attr($storage->get_image_url($image, 'thumb')); ?>"
                           data-image-id="<?php echo esc_attr($image->{$image->id_field}); ?>"
                           data-title="<?php echo esc_attr($image->alttext); ?>"
                           data-description="<?php echo esc_attr(stripslashes($image->description)); ?>"
                           <?php echo $effect_code ?>>
                            <img
                                title="<?php echo esc_attr($image->alttext)?>"
                                alt="<?php echo esc_attr($image->alttext)?>"
                                src="<?php echo esc_attr($storage->get_image_url($image, $thumbnail_size_name, TRUE))?>"
                                width="<?php echo esc_attr($thumb_size['width'])?>"
                                height="<?php echo esc_attr($thumb_size['height'])?>"
                                style="max-width:none;"
                            />
                        </a>
                    </div>
                    <?php

                    $this->end_element();

                    ?>
                </div>
                <?php

                $this->end_element();

                ?>

            <?php if ($number_of_columns > 0): ?>
                <?php if ((($i + 1) % $number_of_columns) == 0 ): ?>
                    <br style="clear: both" />
                <?php endif; ?>
            <?php endif; ?>

        <?php endfor ?>

@sirion89 – Does the ImageBrowser work if you use the original files?

– Cais.

Hello,

sorry but i was out for a week. Just tested with the original files and the behaviour is the same. Is there some particular option i should check? I tried to compare online settings with the locals one and they are the same if i didn’t miss anything.

@sirion89 – The example site still leads to ImageBrowser displays using extensive customizations … what do you see if your use the default (read: blank) template instead?

– Cais.

The site above is our production server and i can’t use the “blank” one there or it will screw up the intended behaviour. The test i’ve made is on a test site which has the same configuration as the prod one and what I see is the grid w/o the extra html stuff but all the images link to their .jpg file which isn’t what i want.

Could it be related to some option change between the 2 version? i don’t really know where to look.

If i can grab some debug stuff somewhere that can help you just say, i have full access on that site.

@sirion89 – We can start with a link to a specific display on that “test” site.

– Cais.

Ok,it took my company a bit but i have now a test site, link here: Link to test site

as you can see (a part from css style thing) now i set album to extended display,gallery to image thumb and activated the imagebrowser effect,now as you can see from the gallery page all the images link to their .jpg or whatever file which obviouslly bypass the imagebrowser setting.

What i would like, which is working on the old version,is to have all the images open in a new page.

Tell me what do you need for further test.

@sirion89 – Have you tried setting under Gallery > Gallery Settings > NextGEN Basic Thumbnails … Use image browser effect to Yes?

Since you are going through an album display first you need to set the thumbnail display to use the ImageBrowser as a global default.

Thanks!

– Cais.

@photocrati – Ofc i already have that setting, on both of the test site and production site.

My current settings are : Album Extended -> basic gallery thumbnails -> imagebrowser

Waiting for more instruction, if u need i could try to ask and open u an account there so that u can test directly but i would provide credential via email only.

Cheers.

Diego.

@sirion89 – Please send us a Bug Report (https://nextgen-gallery.com/report-bug/ … please reference this topic) so we can get a better look under the page at your site.

We may need log in (and FTP) credentials for your WordPress installation, please include those with your Bug Report, too.

Thanks!

– Cais.

Hello,

i tried to send you a bug report but it looks like that i received no answer. Beside this im trying to dig into your code to understand what cause nextgen to fail when it comes to generate link for the imagebrowser thing.

Actually i don’t know how our customization to the html output could interfer with the link generation, if it could be any setting please let me know which one to look at and i’ll give you a report.

From what i can see in the code everything starts with a

$storage->get_image_url($image, 'full', TRUE))

and then i get kinda lost in the core due to all those magic method (__call) you used there.

If you could give me some instruction or advanced documentation im ready to explore the code and in case i find something i’ll report so that you can fix it.

Cheers,

Diego

Additional info:

I tried to disable ALL my plugins and use the Twentyfifteen Theme with the original nextgen gallery plugin and still the imagebrowser thing was broken…

@sirion89 – If you have not received an answer to your Bug Report yet, then we have not likely received it … please re-submit as needed.

If you have received a response, lets keep the conversation there for the time being.

Thanks!

– Cais.