Icon List gets default color

  • Resolved David

    (@davidvandevoorde)


    2 years, 5 months ago

    The Icon List block is pre-set with a default color of --guten-txt-color. This is unlike the other blocks. I have a default color in my <body>, and this block overrides that.

    Best regards,
    David.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Jegstudio

    (@jegstudio)

    Hi @davidvandevoorde ,

    Some of our blocks have default color variables which put in the body, it shouldn’t override the icon list’s color you set from global style or panel.
    Could you explain more detail what it overrides?

    Thank you.

    Thread Starter David

    (@davidvandevoorde)

    Hello,

    I will try to explain it better.
    I use my own custom CSS, and I have put in my <body> a default color, like color: #aabbcc; This is so my text has everywhere the same color.

    When I add the block Gutenverse Icon List, it automatically uses a different color, like color: var(--guten-txt-color).

    Of course, I can specify my own color for this block, but this causes me extra work and possible errors. I simply don’t want any color specified.

    Best regards,
    David.

    Plugin Author Jegstudio

    (@jegstudio)

    Hi @davidvandevoorde ,

    Since the block has it’s own default color, unfortunately you need to set the color for the block itself.
    To make it easier, instead of selecting the color value every time for each blocks, you can set a global color variable using the global style feature in the top right corner of the editor page. Then you can select the global color from our blocks color control.

    Let us know if you have any question.

    Thank you.

    Thread Starter David

    (@davidvandevoorde)

    Hello,

    I understand what you mean.

    I still have some thoughts running through my head:

    • What happens for a theme that wants to set a standard color for its text? Is that then also overridden when using this block?
    • If your plugin wants a default color, why is the block not using the provided feature for setting the color? The way it is implemented now, is like behind-the-scenes ‘magic’, no?
    • Perhaps in the Global Styling, you should add a feature for specifying the default colors for the blocks?
    • Honestly, I don’t understand why the plugin wants to use some default colors. Styling should be part of a theme, not of the blocks. Don’t you think?

    You don’t need to answer all the questions ?? Just let it sink in, and see if perhaps you can adjust the way the plugin is developed.

    Best regards,
    David.

    • This reply was modified 2 years, 5 months ago by David.
    Plugin Author Jegstudio

    (@jegstudio)

    Hi @davidvandevoorde ,

    We understand and appreciate your thoughts regarding this topic.
    There are few reasons and decisions made while developing the plugin, including the default colors.
    We might or might not consider to change this in the future, we can’t promise that.
    Thank you for your feedback.

    Best Regards.

    Thread Starter David

    (@davidvandevoorde)

    Hello,

    Thank you for your consideration.

    Since for now you see this thing as a feature, not an error, which I understand, I will close this ticket.

    Best regards,
    David.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Icon List gets default color’ is closed to new replies.