• Resolved goodyis

    (@goodyis)


    i.sharethis.js was constantly making load-time increase by minutes…

    Not sure if there was a built in way already; but it seems to be resolved for at-least for the moment by forcing it to load asynchronously.

    Modified -> /class/GA_Frontend.php line 5 to:
    const GA_SHARETHIS_PLATFORM_URL = '//platform-api.sharethis.com/js/sharethis.js#asyncload';

    Modified my functions.php to include:

     // Async load
    function ikreativ_async_scripts($url)
    {
        if ( strpos( $url, '#asyncload') === false )
            return $url;
        else if ( is_admin() )
            return str_replace( '#asyncload', '', $url );
        else
    	return str_replace( '#asyncload', '', $url )."' async='async"; 
        }
    add_filter( 'clean_url', 'ikreativ_async_scripts', 11, 1 );

    fix source from: https://ikreativ.com/async-with-wordpress-enqueue/

Viewing 11 replies - 1 through 11 (of 11 total)
  • Hi @goodyis,

    Thanks for reaching out and reporting on this issue.
    I’ll have our developer team look into this and report back on our findings.
    In the meantime, do you happen to have a screenshot of what you saw on your end? And are you still experiencing the hanging issue?

    Thanks, hope to learn more soon!

    Brandon

    Thread Starter goodyis

    (@goodyis)

    I’m not seeing it as much now; I’ve been trying to get a screenshot of the ‘Network’ tab in my console – chrome; but of course it hasn’t happened this go around.

    I’d change back the code, or even deactivate other plugins; but this is on a live site. So I will not be doing that.

    I’ve got your plugin running on a few sites and don’t recall seeing the issue on them. I’ve basically got the same plugins/functions on the sites; the only difference being the base theme – with them all having customized child-themes.

    The theme I’m using there is Jupiter 5.6. WordPress 4.7.2.

    Some screenshots here:
    https://drive.google.com/open?id=0ByWCUyUbezJ0aXYwNDhzMzJYTFU

    ~JG

    Thread Starter goodyis

    (@goodyis)

    Just caught it, after pressing refresh, letting the page load, and pressing refresh again. Still waiting actually; and I’m sure if I just let it sit it won’t load. But I know if I press refresh again it would load.

    This time it is ‘waiting’ on platform-api.sharethis.com
    The previous times I noticed it, it was ‘waiting’ on i.sharethis.com

    I uploaded a screenshot of it to that same folder/link above.

    Thread Starter goodyis

    (@goodyis)

    Welp, its happening on another site; that I didn’t edit/change your code on; and really has no ‘theme’ per say – its completely custom.

    I’ve uploaded a screenshot of it; it took 20 seconds to load-in platform-api.sharethis.com and is now ‘waiting’ on i.sharethis.com.

    And as you will see from the time stamp on the newest screenshot; it has been 5 minutes, and it still hasn’t loaded.

    Side note, the ‘orig’ page I captured the network activity from is still ‘loading/waiting’ from some 31 minutes ago or so.

    Now, I opened the same site in an incognito window and it loaded – so again it doesn’t happen all the time.

    • This reply was modified 8 years, 1 month ago by goodyis.
    • This reply was modified 8 years, 1 month ago by goodyis. Reason: corrected 'orig' wait time

    Hi @goodyis,

    Thanks so much for this feedback and really appreciate the screenshots.
    Can you provide the URLs to all your domains so I can have our developer team replicate the issue you’re seeing?

    Thanks again!
    Brandon

    Thread Starter goodyis

    (@goodyis)

    I Just added two more screenshots; because it shows 1.5hrs load time for one resource and 2 hr for another.

    They still didn’t load they just cancelled themselves.

    I’d rather not post them on here.
    Could I get an email address to email them to you?

    Hi @goodyis,

    Certainly, please email all the domains so we can review them on our end!
    Our email is [email protected].

    Thank you and hope to help soon!
    Brandon

    Thread Starter goodyis

    (@goodyis)

    I did yesterday at 2:25PM with the subject “In regards to post-8836592”

    Hi @goodyis,

    We have yet to receive your email, can you please try sending it again? Or to our other email address [email protected]

    Thank you!

    Thread Starter goodyis

    (@goodyis)

    It has been two weeks guys; script is still hanging.

    Thread Starter goodyis

    (@goodyis)

    It has been a month.
    Still have not heard from you guys after sending in an email 3 weeks ago with details.

    I’ve updated each time, and still hangs; badly.

    I have uninstalled for the most part and just manually added tracking back in.
    = no dashboard (what I did like about your plugin)
    = no more hanging (what I couldn’t intentionally allow)

    If I don’t delete it from other stage installs; I might see if I can’t get it to work again… but maybe not.
    – I’ve seen too many other comments about what they called ‘malicious injections;’ now, I would not go as far as malicious by any stretch, but something for sure is not ‘kosher.’

    • This reply was modified 8 years ago by goodyis. Reason: Not truly resolved, but resolved in the sense that I've moved on
Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘i.sharethis.js hangs-up load time’ is closed to new replies.