I have fixed a bug, please apply

  • Resolved liveweltdigital

    (@liveweltdigital)


    4 years, 1 month ago

    Hello, I use the plugin in a project and have fixed a bug in your plugin for it.

    File: “svg-support/js/svgs-inline.js“.
    Line 11 is missing a check if the SRC attribute is present at all.
    Fix:

    if ( typeof jQuery(this).attr('src') !== typeof undefined && jQuery(this).attr('src') !== false) {
	// Pick only those with the extension we want
	if ( jQuery(this).attr('src').match(/\.(svg)/) ) {

		// Add our class name
		if ( !jQuery(this).hasClass(cssTarget.ForceInlineSVG) ) {
			jQuery(this).addClass(cssTarget.ForceInlineSVG);
		}
	}
}

    Best regards
    Chris

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Benbodhi

    (@benbodhi)

    Thanks Chris!

    I’ll be working on this very soon and will look at including this code ??

    Plugin Author Benbodhi

    (@benbodhi)

    Well it took ages, but I finally added this in.
    Thanks again for pointing it out and providing the solution!

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘I have fixed a bug, please apply’ is closed to new replies.