HTTPS only sites

  • Hello,
    I think there is something missing from the plugin.

    Looking at line 194 the current domain is created with untrailingslashit(esc_url($_SERVER['SERVER_NAME'])). Won’t this be https:// prefixed regardless of whether HTTPS is in use? That’s why comparison fails in line 199.

    I think you could give current protocol as a parameter to esc_url.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author matthias.wagner

    (@matthiaswagner)

    hy,
    thanks for the input. i am aware of some issues like this in the code which need to be resolved in a future update. unfortunately it looks like this will not happen before the end of 2018, since this is only a by-product of our agency and for our clients everything works so far…
    to use it in a https-environment it’s best to add both http and https version like explained in the screenshots and faq. hope this works for you ??

    matt

    Thread Starter kpressaccount

    (@kpressaccount)

    Absolutely, no problem. ?? I’ll figure out the missing parts myself at some point. Luckily the plugin is well made and really minimal. ??

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘HTTPS only sites’ is closed to new replies.