How to contribute ?

  • Resolved mickaelperrin

    (@mickaelperrin)


    6 years, 3 months ago

    Hi,

    We plan to use this plugin by default on our websites.

    Sadly, it throws a 500 error as soon as there is a 404 on a css file.

    The fix is simple, replace at line 930 of inc/functions.php $data by $curl.

    However, we don’t see any way to subit pull requests or to contribute to the plugin.

    Are there any plans to make the plugin available on github ?

    Thanks

Viewing 1 replies (of 1 total)
  • Plugin Author Raul P.

    (@alignak)

    Hi @mickaelperrin

    Thanks for reporting.
    The reason why I am not putting it to github, is because I am still actively developing it and adding new features. Some days, I may release 5 or 6 updates within a week and I don’t want the trouble of looking for other developers code.

    I am planning on adding it there eventually, when I feel it has matured enough that I won’t be adding new features soon.

    For now, reporting it here or via fastvelocity.com would be way ??

    —

    I spotted the error you referred (thanks) and I’ll push it on an update today, together with a couple more changes I am working on right now.

    However, if you have an error 500 if the CSS file doesn’t exist…

    First, if the file doesn’t exist, that means there is an error somewhere else and that a plugin or your theme is enqueuing it wrong.

    Second, that function fastvelocity_download is used to not only download CSS but JS files, so the potential is there for both situations.

    Third, that specific line is a curl fallback, for when wp_remote_get and wp_remote_retrieve_response_code fails (but it makes sense it would fail if the file returns a 404).

    So in short, I’ll have to check for the curl response and watch it for a 200 response header instead of just replacing that variable.

Viewing 1 replies (of 1 total)
  • The topic ‘How to contribute ?’ is closed to new replies.