• Resolved benbakelaar

    (@benbakelaar)


    SideMenu is working great! Have purchased the upgrade too.

    But with the Astra theme, after the SideMenu successfully loads (it hijacks), if you close the menu with the X, then the theme’s mobile menu appears underneath.

    It’s strange because there is NO mobile menu set for the theme itself. So my working theory right now is that the Sidemenu hijack is somehow triggering this other mobile menu to display.

    The page I need help with: [log in to see the link]

Viewing 13 replies - 1 through 13 (of 13 total)
  • Plugin Author Oliver Campion

    (@domainsupport)

    Thanks for reporting this issue. It was being caused by sites that use Astra theme and jQuery.

    We have just pushed an update that should fix the problem. Please update the plugin and confirm.

    Oliver

    Thread Starter benbakelaar

    (@benbakelaar)

    Thanks so much for the quick update! I installed it earlier and cleared the server-side cache on the host, but so far it is still loading the double menu for me in Chrome on an Android phone (Motorola). It’s a little hard to clear cache on a mobile browser, so not sure if that’s it… especially if it’s some piece of Javascript that the browser is hanging on to.

    Plugin Author Oliver Campion

    (@domainsupport)

    OK, this was my bad … not sure how I didn’t notice this. Also found that the resize event in the customizer mobile view was re-enabling the Astra theme mobile menu events!

    Anyway, several hours of head scratching later and I think I’ve fixed it.

    Please test latest version.

    Thanks,

    Oliver

    Thread Starter benbakelaar

    (@benbakelaar)

    Thank you very much, testing now!

    Plugin Author Oliver Campion

    (@domainsupport)

    Marking this as “resolved”.

    Oliver

    Thread Starter benbakelaar

    (@benbakelaar)

    Hi! We are live now, at njrise.org, and the issue still occurs on mobile device. It can vary when you are on desktop and shrink the width to mobile, sometimes the 2nd “default” mobile menu does not appear. But on my Android device, it still reveals a mobile menu underneath the SideMenu.

    Plugin Author Oliver Campion

    (@domainsupport)

    Oh no! OK, so we’ve taken another look at this and made a minor change to the JavaScript. Can you please download the latest version as we believe this should finally resolve this issue!

    Oliver

    Thread Starter benbakelaar

    (@benbakelaar)

    Tried again, but no luck! I tried turning off “Hijack mobile menu” and setting the SideMenu as the menu in the “Mobile” position/area in theme settings, but then it simply didn’t display SideMenu.

    Let me submit this as a bug to Astra theme and see. There is currently no menu set for mobile in Astra, yet it generates an “all pages” menu on its own (which now shows up on live site after you close out SideMenu).

    Thanks for your help, will keep you posted!

    Plugin Author Oliver Campion

    (@domainsupport)

    We can see the issue on your site but unfortunately, on our test site with Astra theme enabled, this behaviour is not replicated.

    Unless we can replicate the issue we will not be able to solve it!

    I’m afraid that the Astra theme developers will not see this as a bug and even if they do, if their mobile menu didn’t generate an “all pages” menu on it’s own then it wouldn’t show the toggle icon either which wouldn’t help you.

    I cannot understand why this doesn’t work on your site. The sidemenu.js code waits for Astra theme JavaScript to load its events then it un-hooks them to prevent the default action from being fired when you click the toggle button.

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    Hang on … are you using this version of the theme? This is the version we have on our test server.

    Or is it one of the ones on their site?

    Please advise.

    Many thanks,

    Oliver

    Thread Starter benbakelaar

    (@benbakelaar)

    Yep… we were on version 3.2.0.

    I just set up a staging site and upgraded to 3.6.2, and it appears to be working now! I guess some JS must have changed between 3.2 and 3.6.2, since you were able to replicate the issue with your own testing which began with 3.6.2?

    Btw I do see a sort of phantom / fast load (and close) of something when I click the mobile menu button and the SideMenu appears. I assume that’s the resize event that you mention above. It’s not an issue, just a note that it’s visible upon close inspection.

    Plugin Author Oliver Campion

    (@domainsupport)

    Oh right! That’s a relief!

    OK, so I think you are describing the animation that shifts the whole site when the SideMenu is opened or closed.

    This can be turned off by using “Customizer – SideMenu – No Content Animation” option.

    Oliver

    Plugin Author Oliver Campion

    (@domainsupport)

    Marking this as “resolved” now.

    Oliver

Viewing 13 replies - 1 through 13 (of 13 total)
  • The topic ‘Hijack mobile bug with Astra theme’ is closed to new replies.