Half working

@digiblogger

I do not clearly understand, is the shortcode working in the links or not? You said you need to add this function to make it work

add_filter('wp_nav_menu', 'do_menu_shortcodes');
function do_menu_shortcodes( $menu ){
        return do_shortcode( $menu );
}

but from what I’ve coded, it should have been taken care of already. If this is needed, then it needs to be implemented in the plugin itself.

I’ll be willing to help you out with the issues you’re facing while using this plugin, but will need somewhat more detailed info as to whats going wrong.

And be assured, the custom links shortcode is not going anywhere, its the soul of this plugin and will work as it is, and even better once I implement the shortcodes in titles as well.

I think you misunderstood.

The plug-in does not work for me without adding the function to enable menu shortcodes to my themes function.php.

Then we have to ways of adding shortcodes to menu.

The way you call “old method” works for me
The one you call “new method” shows absolutely nothing in front end. No plain text, no HTML, no shortcodes.

So I ask you not to remove the old method because this is the only working.
I don’t get the results of the new method like shown in your Screenshots.

I will tell you, what is going on there:

As you know, wordpress Custom Links in Custom Menus remove brackets when entered in URLs. So, when you create a custom Link like….

Title: Any Title
Url: http/[shortcodeformysite]

and hit save after this, you can look at this item and will find:

Title: Any Title
Url: http/shortcodeformysite (in plain text).

When I activate the plugin, this behaviour changes and the brackets are not removed anymore. But: The Shortcode is′t executed in the front end.

When I add this to my functions.php:

add_filter('wp_nav_menu', 'do_menu_shortcodes');
function do_menu_shortcodes( $menu ){
        return do_shortcode( $menu );
}

this behaviour changes too:

now, any shortcode entered in the URL of a Custom Link in Custom WordPress Menu is executed in the frontend.

So, from my point of view:

Your plugin forces wordpress to accept brackets in the menus URLs, but does not offer the possibility to execute them in the frontend.

This was the “old way”.

The new way is to use the new “shortcode” element in the custom menu section, like described in your plugins screenshots.

But using this, does nothing for me. I can select it and enter a title and a shortcode in his content and when hitting “add to menu”, it is shown in the menu. In the backend.
In frontend, there is absolutely nothing shown. There is no new menu item and even I place the shorcode element as a submenu, there is still nothing shown in frontend.
So, from my point of view, the shortcode element does not do anything, but only appear in the backend.

I am not a coder… I know some basics, but I can not really create complicated plugins.
But I had a look at your main php file and found that:

* Allows shortcode to be processed and displayed
         *
         * @deprecated since 2.0
         *
         * @param string $url The processed url for displaying/saving
         * @param string $orig_url The url that was submitted, retreived
         * @param string $context Whether saving or displaying
         * @return string
         */
        public function display_shortcode($url, $orig_url, $context) {
            if ($context == 'display') {
                return do_shortcode($orig_url);
            }
            return $url;
        }

I think, this is the function, that should to the same like my code. But in my tested themes, this does′t work.

digiblogger

I’m not really sure why its not working with your themes, but as far as I’ve tested, its working with the default WordPress themes, without an issue.

If you can point me out to one of the themes, where its not working with, maybe then I can find and resolve the issue.