Greenshift VideoBox aspect-ratio by default hardcoded to 16/9. Should be unset!

Unfortunately without aspect ratio most of video players will use default width which is usually zero so video will be not visible. Currently we don’t plan to remove default aspect ratio

1) Which web browsers display no video when having no aspect ratio set?

• Could you list concrete examples please?
• I tested Chrome and Safari on macOS + iOS,
• Chrome and Edge on Windows,
• and Chrome on ChromeOS,
• and they all display the native video block fine, which uses no aspect-ratio attribute! Neither on its video element, nor the figure.
• Maybe you once experienced that on some very special device or browser, and took this precaution as a general necessity?

2) If you bring forward a valid argument why Greenshift must ship with a default aspect-ratio of 16/9 for all video material, then fine, let’s have a default one, but then please in the UI offer an explicit aspect-ratio option “None” (aka “Original” aka “Like Source”), with which you can unset the aspect-ratio, if one deems that necessary, like me, who has a lot of video content in 1:1 or 4:3 or some very custom aspect ratios which cannot even be expressed with a 1-2 digit fraction.

• This reply was modified 1 year, 8 months ago by abitofmind.

This is what will happen to video block with disabled Ratio

https://monosnap.com/file/Ko306G0XsAv17rnrYCgb1fsTzWPgen

In current point we don’t plan to remove it. But I can remove it for inline Videos if this will help you

1) You send me a screenshot without any contextual info.

• Video type: Youtube (as can be seen on the screenshot). Very specific issue as Youtube displays a lot of extra UI elements on top of the video.
• What for videos hosted in the media library (MP4, WEBM, etc)?
• Which web browser was used for the Block Editor on the screenshot?
• Web browser used for viewing. Which one had issues?

2) Please remove the aspect ratios for inline videos.

Although again what is an “inline video” exactly?
a) In the true HTML/layouting sense as in “a video inline on a line of text” so for mini videos which are maybe 24px-48px high surrounded by text left from it and then continued with text after it? That’s a very very edge case almost no-one needs, neither me. I display my videos only as blocks.
b) Or do you mean videos coming from the Media Library (served from your own web server or CDN, instead of a video provider like Youtube or Vimeo? Then yes please remove the aspect ratios for the Media Library videos or other external URLs! B/c all of these worked fine in my tested web browsers both in the Block Editor and the Frontend.

• This reply was modified 1 year, 7 months ago by abitofmind.

there are some changes in video block, if you still have issues, you can reopen

All feedback I gave has now been fixed, thanks!

? The ?video.gs-video-element? has no more?aspect-ratio attribute in its default setting or when choosing “Auto”. If one wants an Aspect ratio one can still set it, and it works as expected.

? The bottom gap below the video box which layout-wise was treated as an inline element does not occur anymore due to now being an explicit block element .gs-video video { display: block; }

Found one more misbehavior which I filed in a followup bug report:

? Greenshift Video block should use box-sizing: border-box to stay within layout

?? Re-opening: You and me we both oversaw one aspect:

With ?? Enable Overlay or Lightbox and ?? Enable Lightbox the block still has a hard-coded aspect ratio of 16/9. Please fix that too.

Plus I noted another issue with the Lightbox not related to the aspect ratio, which I filed separately: Video with Lightbox ON: In pageflow shows only box in overlay color but no video.