Google Closure Breaks Javascript

  • Resolved launchinteractive

    (@launchinteractive)


    3 years, 7 months ago

    When you use Google Closure to compress wootpm.js it has trouble with the varExists function. 

    if (typeof varExists !== "function") {
    function varExists(varName) {

    becomes:

    if("function"!==typeof varExists)var varExists$0=function(a){

    which is incorrect. To correct this I believe this is all that needs to change:

    if (typeof varExists !== "function") {
    window.varExists = function(varName) {
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author alekv

    (@alekv)

    I’ll look into it. It looks logical and simple. But I remember having had issues with a function trying to declare it under window. For some reason it broke, even if it shouldn’t. So I’ll have to carefully test it.

    I’ll let you know what I find out in the next few days.

    • This reply was modified 3 years, 7 months ago by alekv.
    • This reply was modified 3 years, 7 months ago by alekv.
    Thread Starter launchinteractive

    (@launchinteractive)

    Thanks. It should also work without window but I added it to make it clearer that it is a global function.

    Plugin Author alekv

    (@alekv)

    I released a new version with that code adjusted.

    Let me know if it works.

    Thread Starter launchinteractive

    (@launchinteractive)

    That’s done it. Works great. Thanks.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Google Closure Breaks Javascript’ is closed to new replies.