gmap and protocol-relative URL

  • Hello there,

    I’m running this plugin on an https enabled site. When I use the su_gmap shortcode the google map won’t show up as it is hardcoded with http, see:

    /shortcodes-ultimate/inc/core/shortcodes.php line 974

    return '<div class="su-gmap su-responsive-media-' . $atts['responsive'] . su_ecssc( $atts ) . '"><iframe width="' . $atts['width'] . '" height="' . $atts['height'] . '" src="https://maps.google.com/maps?q=' . urlencode( su_scattr( $atts['address'] ) ) . '&output=embed"></iframe></div>';

    would you mind changing to a protocol relative URL in your next plugin update?

    return '<div class="su-gmap su-responsive-media-' . $atts['responsive'] . su_ecssc( $atts ) . '"><iframe width="' . $atts['width'] . '" height="' . $atts['height'] . '" src="//maps.google.com/maps?q=' . urlencode( su_scattr( $atts['address'] ) ) . '&output=embed"></iframe></div>';

    This way it will work on http and https sites …

    Thanks a lot for your awesome plugin ??

    Greetings & all the best
    Becki

  • The topic ‘gmap and protocol-relative URL’ is closed to new replies.