French Translation – Traduction en Fran?ais

Which line/lines is it specifically again? The ones from the shortcode list above?

What attributes are you using for the shortcode, so I can see if I can recreate.

From 2085 to 2106 of my .po file.
Here is my shortcode :

[badgeos_achievements_list show_filter=true show_search=true]

??

Definitely recreating the problem, and double checking on the ability to move the %s’s. I may be learning something new here.

How are you doing the translating? plain text file? Codestyling Localization? Poedit?

I found once I saved and regenerated the accompanying mo file, the translation kicked in in the right order.

https://cl.ly/image/0N18011a0i1H

The .po file was generated with Codestyling Localization. I then put the .po file online on the cloud9 editor. From them, I can edit with collaborators. I then download the file back to my computer and convert into .mo via .po edit while cheking for erros (characters, spaces, encoding etc…).

As I can see on your screenshot, the %s returns “achivements”, just as for me. If would have returned “Badge” cause it is the name of my achievement.
Same problem with english version : %s returns “achivements” and not the achivements type name.

Aha…another mental trigger finally went off.

This is actually proving to be a 2 part issue.

One, you’re setting the shortcode to display “all achievements” and thus the code is not trying to separate out by individual type. It’s just using “achievements” as a catch-all.

see:

// If we're dealing with multiple achievement types
if ( 'all' == $type ) {
	$post_type_plural = 'achievements';
} else {
	$types = explode( ',', $type );
	$post_type_plural = ( 1 == count( $types ) ) ? get_post_type_object( $type )->labels->name : 'achievements';
}

the $post_type_plural is what’s passed into the option values.

However, these are two spots that we have missed for gettext spots as well. So we’ll need to get that fixed and get the pot files updated. Not sure when that will go out in a proper release though, so not sure how soon you could get it taken care of.

Regardless, this got pointed out, and should be fixed more sooner than later.

YEAH ! This one was not easy !

nice job, waiting for the next release. ??

For reference:
https://github.com/opencredit/badgeos/issues/370